Issue 10784026: Merge 146819 - A small defect was introduced with the refactoring of this file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10784026: Merge 146819 - A small defect was introduced with the refactoring of this file. (Closed)

Created:
8 years, 5 months ago by Mike Mammarella

Modified:
8 years, 5 months ago

Reviewers:
cristian.patrasciuc

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1180/src/

Visibility:
Public.

More Reviews

Description

Merge 146819 - A small defect was introduced with the refactoring of this file. The freedesktop method for uninhibit is called with a wrong name, giving this type of errors on KDE: [22381:22390:37538866338:ERROR:power_save_blocker_linux.cc(289)] No response to Uninhibit() request! BUG=137538 TEST=none Tests-Missing Review URL: https://chromiumcodereview.appspot.com/10780012 TBR=cristian.patrasciuc@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146895

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/power_save_blocker_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cristian.patrasciuc

8 years, 5 months ago (2012-07-19 19:25:52 UTC) #3

On 2012/07/19 19:24:04, cristian.patrasciuc wrote:
> lgtm

I'm not sure if you waited for a 'lgtm' or not, since I don't know what TBR
means. I sent one anyway.

Expand Messages | Collapse Messages