Place source URL of DownloadFile in extended attributes

content/browser/download/file_metadata_unittest_linux.cc

Index: content/browser/download/file_metadata_unittest_linux.cc
===================================================================
--- content/browser/download/file_metadata_unittest_linux.cc	(revision 0)
+++ content/browser/download/file_metadata_unittest_linux.cc	(revision 0)
@@ -0,0 +1,165 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <errno.h>
+#include <sys/types.h>
+#include <sys/xattr.h>
+
+#include <algorithm>
+#include <sstream>
+#include <string>
+
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/logging.h"
+#include "base/scoped_temp_dir.h"
+#include "base/string_split.h"
+#include "content/browser/download/file_metadata_linux.h"
+#include "googleurl/src/gurl.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {

[darin (slow to review), 2012/07/26 18:47:00]

you can also put the test in the content namespace so you don't need to write
content:: in front of content bits.

namespace content {
namespace {

...

}  // namespace
}  // namespace content

+
+using std::istringstream;
+using std::string;
+using std::vector;
+
+class FileMetadataLinuxTest : public testing::Test {
+ public:
+  FileMetadataLinuxTest()
+      : source_url_("http://www.source.com"),
+        referrer_url_("http://www.referrer.com") {}
+
+  const FilePath& test_file() const {
+    return test_file_;
+  }
+
+  const GURL& source_url() const {
+    return source_url_;
+  }
+
+  const GURL& referrer_url() const {
+    return referrer_url_;
+  }
+
+  bool is_xattr_supported() const {
+    return is_xattr_supported_;
+  }
+
+ protected:
+  virtual void SetUp() OVERRIDE {
+    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+    ASSERT_TRUE(file_util::CreateTemporaryFileInDir(temp_dir_.path(),
+                                                    &test_file_));
+    int result = setxattr(test_file_.value().c_str(),
+                          "user.test", "test", 4, 0);
+    is_xattr_supported_ = (!result) || (errno != ENOTSUP);
+    if (!is_xattr_supported_) {
+      LOG(INFO) << "Test will be skipped because extended attributes are not "
+                << "supported on this OS/file system.";
+    }
+  }
+
+  void CheckExtendedAttributeValue(const string attr_name,
+                                   const string expected_value) const {
+    ssize_t len = getxattr(test_file().value().c_str(), attr_name.c_str(),
+                           NULL, 0);
+    if (len <= static_cast<ssize_t>(0)) {
+      FAIL() << "Attribute '" << attr_name << "' does not exist";
+    }
+    char* buffer = new char[len];
+    len = getxattr(test_file().value().c_str(), attr_name.c_str(), buffer, len);
+    EXPECT_EQ(expected_value.size(), static_cast<size_t>(len));
+    string real_value(buffer, len);
+    delete[] buffer;
+    EXPECT_EQ(expected_value, real_value);
+  }
+
+  void GetExtendedAttributeNames(vector<string>* attr_names) const {
+    ssize_t len = listxattr(test_file().value().c_str(), NULL, 0);
+    if (len <= static_cast<ssize_t>(0)) return;
+    char* buffer = new char[len];
+    len = listxattr(test_file().value().c_str(), buffer, len);
+    attr_names->clear();
+    base::SplitString(string(buffer, len), '\0', attr_names);
+    delete[] buffer;
+  }
+
+  void VerifyAttributesAreSetCorrectly() const {
+    vector<string> attr_names;
+    GetExtendedAttributeNames(&attr_names);
+
+    // Check if the attributes are set on the file
+    vector<string>::const_iterator pos = find(attr_names.begin(),
+        attr_names.end(), content::kSourceURLAttrName);
+    EXPECT_NE(pos, attr_names.end());
+    pos = find(attr_names.begin(), attr_names.end(),
+        content::kReferrerURLAttrName);
+    EXPECT_NE(pos, attr_names.end());
+
+    // Check if the attribute values are set correctly
+    CheckExtendedAttributeValue(content::kSourceURLAttrName,
+                                source_url().spec());
+    CheckExtendedAttributeValue(content::kReferrerURLAttrName,
+                                referrer_url().spec());
+  }
+
+ private:
+  ScopedTempDir temp_dir_;
+  FilePath test_file_;
+  GURL source_url_;
+  GURL referrer_url_;
+  bool is_xattr_supported_;
+};
+
+TEST_F(FileMetadataLinuxTest, CheckMetadataSetCorrectly) {
+  if (!is_xattr_supported()) return;

[Paweł Hajdan Jr., 2012/08/29 16:17:14]

nit: Each statement should be on its own line. Please move the return to new
line, same below.

+  content::AddOriginMetadataToFile(test_file(), source_url(), referrer_url());
+  VerifyAttributesAreSetCorrectly();
+}
+
+TEST_F(FileMetadataLinuxTest, SetMetadataMultipleTimes) {
+  if (!is_xattr_supported()) return;
+  content::AddOriginMetadataToFile(test_file(),
+      GURL("http://www.dummy.com"), GURL("http://www.dummy.com"));
+  content::AddOriginMetadataToFile(test_file(), source_url(), referrer_url());
+  VerifyAttributesAreSetCorrectly();
+}
+
+TEST_F(FileMetadataLinuxTest, InvalidSourceURLTest) {
+  if (!is_xattr_supported()) return;
+  GURL invalid_url;
+  vector<string> attr_names;
+  content::AddOriginMetadataToFile(test_file(), invalid_url, referrer_url());
+  GetExtendedAttributeNames(&attr_names);
+  EXPECT_EQ(attr_names.end(), find(attr_names.begin(), attr_names.end(),
+      content::kSourceURLAttrName));
+  CheckExtendedAttributeValue(content::kReferrerURLAttrName,
+                              referrer_url().spec());
+}
+
+TEST_F(FileMetadataLinuxTest, InvalidReferrerURLTest) {
+  if (!is_xattr_supported()) return;
+  GURL invalid_url;
+  vector<string> attr_names;
+  content::AddOriginMetadataToFile(test_file(), source_url(), invalid_url);
+  GetExtendedAttributeNames(&attr_names);
+  EXPECT_EQ(attr_names.end(), find(attr_names.begin(), attr_names.end(),
+      content::kReferrerURLAttrName));
+  CheckExtendedAttributeValue(content::kSourceURLAttrName, source_url().spec());
+}
+
+TEST_F(FileMetadataLinuxTest, InvalidURLsTest) {
+  if (!is_xattr_supported()) return;
+  GURL invalid_url;
+  vector<string> attr_names;
+  content::AddOriginMetadataToFile(test_file(), invalid_url, invalid_url);
+  GetExtendedAttributeNames(&attr_names);
+  EXPECT_EQ(attr_names.end(), find(attr_names.begin(), attr_names.end(),
+      content::kSourceURLAttrName));
+  EXPECT_EQ(attr_names.end(), find(attr_names.begin(), attr_names.end(),
+      content::kReferrerURLAttrName));
+}
+
+}  // namespace