Add all of base.gyp to the iOS 'All' target

Add all of base.gyp to the iOS 'All' target

Excludes the check_example target on iOS; it would need to be made into
a bundled target, and it's not worth the effort since there's no reason
to do CHECK change testing on iOS instead of Mac.

TBR=
BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146784

[rohitrao (ping after 24h), 2012-07-15 13:27:20]

https://chromiumcodereview.appspot.com/10784006/diff/1/base/base.gyp
File base/base.gyp (right):

https://chromiumcodereview.appspot.com/10784006/diff/1/base/base.gyp#newcode984
base/base.gyp:984: ['OS!="ios"', {
Maybe move this to the bottom?  It's the only != condition in this set, so it
seems out of place.

https://chromiumcodereview.appspot.com/10784006/diff/1/build/all.gyp
File build/all.gyp (right):

https://chromiumcodereview.appspot.com/10784006/diff/1/build/all.gyp#newcode13
build/all.gyp:13: '../base/base.gyp:*',
Everything in base compiles now?

[stuartmorgan, 2012-07-15 15:12:36]

https://chromiumcodereview.appspot.com/10784006/diff/1/base/base.gyp
File base/base.gyp (right):

https://chromiumcodereview.appspot.com/10784006/diff/1/base/base.gyp#newcode984
base/base.gyp:984: ['OS!="ios"', {
On 2012/07/15 13:27:20, rohitrao wrote:
> Maybe move this to the bottom?  It's the only != condition in this set, so it
> seems out of place.

Good point. I moved it to the top since it applies to almost everyone, so that
seemed better than the bottom.

https://chromiumcodereview.appspot.com/10784006/diff/1/build/all.gyp
File build/all.gyp (right):

https://chromiumcodereview.appspot.com/10784006/diff/1/build/all.gyp#newcode13
build/all.gyp:13: '../base/base.gyp:*',
On 2012/07/15 13:27:20, rohitrao wrote:
> Everything in base compiles now?

Yep!

[rohitrao (ping after 24h), 2012-07-16 08:29:06]

lgtm

[commit-bot: I haz the power, 2012-07-16 08:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10784006/6001

[commit-bot: I haz the power, 2012-07-16 08:29:15]

Presubmit check for 10784006-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base

[commit-bot: I haz the power, 2012-07-16 08:32:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10784006/6001

[rohitrao (ping after 24h), 2012-07-16 08:32:22]

Adding TBR= as per previous discussion with Mark.

[commit-bot: I haz the power, 2012-07-16 10:12:35]

Change committed as 146784