Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10783037: Don't send a DragLeave to the renderer if we didn't send a DragEnter. (Closed)

Created:
8 years, 5 months ago by dcheng
Modified:
8 years, 5 months ago
Reviewers:
tony, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng
Visibility:
Public.

Description

Don't send a DragLeave to the renderer if we didn't send a DragEnter. BUG=136834 TEST=dragging over an interstitial doesn't crash the renderer Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147371

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M content/browser/web_contents/web_drag_dest_mac.mm View 1 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
Note that I haven't actually tested the fix yet... I'm OOO today but I'll try ...
8 years, 5 months ago (2012-07-17 19:16:34 UTC) #1
tony
Looks reasonable. Please test before landing. LGTM.
8 years, 5 months ago (2012-07-17 19:20:02 UTC) #2
dcheng
+sky for OWNERS approval. I've tested and it does fix crashes when dragging over and ...
8 years, 5 months ago (2012-07-18 18:10:53 UTC) #3
sky
LGTM http://codereview.chromium.org/10783037/diff/1/content/browser/web_contents/web_drag_dest_mac.mm File content/browser/web_contents/web_drag_dest_mac.mm (right): http://codereview.chromium.org/10783037/diff/1/content/browser/web_contents/web_drag_dest_mac.mm#newcode145 content/browser/web_contents/web_drag_dest_mac.mm:145: if ([self onlyAllowsNavigation]) { no {}
8 years, 5 months ago (2012-07-18 20:58:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/10783037/6002
8 years, 5 months ago (2012-07-18 23:51:58 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 02:41:48 UTC) #6
Change committed as 147371

Powered by Google App Engine
This is Rietveld 408576698