Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 10783036: Merge 122224 - Input type=range issue with events not being raised when value set in js (Closed)

Created:
8 years, 5 months ago by danakj
Modified:
8 years, 5 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 122224 - Input type=range issue with events not being raised when value set in js https://bugs.webkit.org/show_bug.cgi?id=84674 Source/WebCore: Fix dispatching of change and click events for the input slider. Prior to the fix, change events were not fired if the new value matched the value at last change notification based on expected behavior for text fields. Clicks were not fired if the thumb element was repositioned under the cursor on mouse down. Patch by Kevin Ellis <kevers@chromium.org>; on 2012-07-10 Reviewed by Kent Tamura. Tests: fast/events/click-range-slider.html fast/events/onchange-range-slider.html * html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromPoint): * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent): LayoutTests: Ensure that click and change events are properly triggered for range sliders. Prior to the fix, change events were not fired if the new value matched the value at last change notification based on expected behavior for text fields. Clicks were not fired if the thumb element was positioned under the cursor on mouse down. Patch by Kevin Ellis <kevers@chromium.org>; on 2012-07-10 Reviewed by Kent Tamura. * fast/events/click-range-slider-expected.txt: Added. * fast/events/click-range-slider.html: Added. * fast/events/onchange-range-slider-expected.txt: Added. * fast/events/onchange-range-slider.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --3 lines) Patch
A + LayoutTests/fast/events/click-range-slider.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/click-range-slider-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/onchange-range-slider.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/onchange-range-slider-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/shadow/SliderThumbElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/EventHandler.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
danakj
8 years, 5 months ago (2012-07-17 18:49:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698