Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: vm/parser_test.cc

Issue 10783035: Create frequently used symbols in the vm isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/parser.cc ('k') | vm/raw_object_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/parser_test.cc
===================================================================
--- vm/parser_test.cc (revision 9829)
+++ vm/parser_test.cc (working copy)
@@ -8,13 +8,14 @@
#include "vm/longjump.h"
#include "vm/object.h"
#include "vm/parser.h"
+#include "vm/symbols.h"
#include "vm/unit_test.h"
namespace dart {
void DumpFunction(const Library& lib, const char* cname, const char* fname) {
- const String& classname = String::Handle(String::NewSymbol(cname));
+ const String& classname = String::Handle(Symbols::New(cname));
Class& cls = Class::Handle(lib.LookupClass(classname));
EXPECT(!cls.IsNull());
@@ -48,7 +49,7 @@
const char* field_name,
bool expect_static,
bool is_final) {
- const String& classname = String::Handle(String::NewSymbol(class_name));
+ const String& classname = String::Handle(Symbols::New(class_name));
Class& cls = Class::Handle(lib.LookupClass(classname));
EXPECT(!cls.IsNull());
@@ -83,7 +84,7 @@
const char* class_name,
const char* function_name,
bool expect_static) {
- const String& classname = String::Handle(String::NewSymbol(class_name));
+ const String& classname = String::Handle(Symbols::New(class_name));
Class& cls = Class::Handle(lib.LookupClass(classname));
EXPECT(!cls.IsNull());
@@ -131,7 +132,7 @@
CheckField(lib, "A", "s2", true, false);
// No field entries are added for static const fields.
String& fieldname = String::Handle(String::New("s3"));
- const String& classname = String::Handle(String::NewSymbol("A"));
+ const String& classname = String::Handle(Symbols::New("A"));
const Class& cls = Class::Handle(lib.LookupClass(classname));
const Field& field = Field::Handle(cls.LookupStaticField(fieldname));
EXPECT(!field.IsNull());
« no previous file with comments | « vm/parser.cc ('k') | vm/raw_object_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698