Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: vm/dart_entry_test.cc

Issue 10783035: Create frequently used symbols in the vm isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/dart_entry.cc ('k') | vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/dart_entry_test.cc
===================================================================
--- vm/dart_entry_test.cc (revision 9829)
+++ vm/dart_entry_test.cc (working copy)
@@ -9,6 +9,7 @@
#include "vm/dart_entry.h"
#include "vm/object.h"
#include "vm/resolver.h"
+#include "vm/symbols.h"
#include "vm/unit_test.h"
namespace dart {
@@ -30,7 +31,7 @@
EXPECT_EQ(true, CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
Class& cls = Class::Handle(
- lib.LookupClass(String::Handle(String::NewSymbol("A"))));
+ lib.LookupClass(String::Handle(Symbols::New("A"))));
EXPECT(!cls.IsNull());
String& name = String::Handle(String::New("foo"));
Function& function = Function::Handle(cls.LookupStaticFunction(name));
@@ -62,7 +63,7 @@
EXPECT_EQ(true, CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
Class& cls = Class::Handle(
- lib.LookupClass(String::Handle(String::NewSymbol("A"))));
+ lib.LookupClass(String::Handle(Symbols::New("A"))));
EXPECT(!cls.IsNull());
String& name = String::Handle(String::New("foo"));
Function& function = Function::Handle(cls.LookupStaticFunction(name));
@@ -90,7 +91,7 @@
EXPECT_EQ(true, CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
Class& cls = Class::Handle(
- lib.LookupClass(String::Handle(String::NewSymbol("A"))));
+ lib.LookupClass(String::Handle(Symbols::New("A"))));
EXPECT(!cls.IsNull());
// Invoke the constructor.
@@ -98,7 +99,7 @@
GrowableArray<const Object*> constructor_arguments(2);
constructor_arguments.Add(&instance);
constructor_arguments.Add(&Smi::Handle(Smi::New(Function::kCtorPhaseAll)));
- String& constructor_name = String::Handle(String::NewSymbol("A."));
+ String& constructor_name = String::Handle(Symbols::New("A."));
Function& constructor =
Function::Handle(cls.LookupConstructor(constructor_name));
ASSERT(!constructor.IsNull());
« no previous file with comments | « vm/dart_entry.cc ('k') | vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698