vm/code_descriptors_test.cc - Issue 10783035: Create frequently used symbols in the vm isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/code_descriptors_test.cc

Issue 10783035: Create frequently used symbols in the vm isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/code_descriptors_test.cc

===================================================================

--- vm/code_descriptors_test.cc (revision 9829)

+++ vm/code_descriptors_test.cc (working copy)

@@ -13,6 +13,7 @@

#include "vm/dart_entry.h"

#include "vm/native_entry.h"

#include "vm/parser.h"

+#include "vm/symbols.h"

#include "vm/unit_test.h"

namespace dart {

@@ -22,7 +23,7 @@

CODEGEN_TEST_GENERATE(StackmapCodegen, test) {

Assembler assembler;

- const String& function_name = String::ZoneHandle(String::NewSymbol("test"));

+ const String& function_name = String::ZoneHandle(Symbols::New("test"));

const Function& function = Function::Handle(

Function::New(function_name, RawFunction::kRegularFunction,

true, false, 0));

@@ -175,7 +176,7 @@

const Library& lib = Library::Handle(Library::LookupLibrary(name));

EXPECT(!lib.IsNull());

Class& cls = Class::Handle(

- lib.LookupClass(String::Handle(String::NewSymbol("A"))));

+ lib.LookupClass(String::Handle(Symbols::New("A"))));

EXPECT(!cls.IsNull());

// Now compile the two functions 'A.foo' and 'A.moo'

« no previous file with comments | « vm/class_finalizer_test.cc ('k') | vm/code_generator.cc » ('j') | no next file with comments »