lib/string.cc - Issue 10783035: Create frequently used symbols in the vm isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/string.cc

Issue 10783035: Create frequently used symbols in the vm isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/string.cc

===================================================================

--- lib/string.cc (revision 9829)

+++ lib/string.cc (working copy)

@@ -7,6 +7,7 @@

#include "vm/exceptions.h"

#include "vm/native_entry.h"

#include "vm/object.h"

+#include "vm/symbols.h"

namespace dart {

@@ -96,7 +97,7 @@

GET_NATIVE_ARGUMENT(Integer, index, arguments->At(1));

uint32_t value = StringValueAt(receiver, index);

ASSERT(value <= 0x10FFFF);

- arguments->SetReturn(String::Handle(String::NewSymbol(&value, 1)));

+ arguments->SetReturn(String::Handle(Symbols::New(&value, 1)));

}

DEFINE_NATIVE_ENTRY(String_charCodeAt, 2) {

« no previous file with comments | « lib/math.cc ('k') | vm/class_finalizer.cc » ('j') | no next file with comments »