Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: vm/parser.cc

Issue 10783035: Create frequently used symbols in the vm isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/parser.cc
===================================================================
--- vm/parser.cc (revision 9729)
+++ vm/parser.cc (working copy)
@@ -18,6 +18,7 @@
#include "vm/object_store.h"
#include "vm/resolver.h"
#include "vm/scopes.h"
+#include "vm/symbols.h"
namespace dart {
@@ -1528,7 +1529,7 @@
return;
}
String& ctor_name = String::Handle(super_class.Name());
- String& ctor_suffix = String::Handle(String::NewSymbol("."));
+ String& ctor_suffix = String::Handle(Symbols::Dot());
ctor_name = String::Concat(ctor_name, ctor_suffix);
ArgumentListNode* arguments = new ArgumentListNode(supercall_pos);
// Implicit 'this' parameter is the first argument.
@@ -1570,7 +1571,7 @@
const Class& super_class = Class::Handle(cls.SuperClass());
ASSERT(!super_class.IsNull());
String& ctor_name = String::Handle(super_class.Name());
- String& ctor_suffix = String::Handle(String::NewSymbol("."));
+ String& ctor_suffix = String::Handle(Symbols::Dot());
if (CurrentToken() == Token::kPERIOD) {
ConsumeToken();
ctor_suffix = String::Concat(
@@ -1756,7 +1757,7 @@
const intptr_t call_pos = TokenPos();
ConsumeToken();
String& ctor_name = String::Handle(cls.Name());
- String& ctor_suffix = String::Handle(String::NewSymbol("."));
+ String& ctor_suffix = String::Handle(Symbols::Dot());
if (CurrentToken() == Token::kPERIOD) {
ConsumeToken();
@@ -2375,7 +2376,7 @@
ExpectToken(Token::kTHIS);
String& redir_name = String::ZoneHandle(
String::Concat(members->class_name(),
- String::Handle(String::NewSymbol("."))));
+ String::Handle(Symbols::Dot())));
if (CurrentToken() == Token::kPERIOD) {
ConsumeToken();
redir_name = String::Concat(redir_name,
@@ -2711,7 +2712,7 @@
}
// We must be dealing with a constructor or named constructor.
member.kind = RawFunction::kConstructor;
- String& ctor_suffix = String::ZoneHandle(String::NewSymbol("."));
+ String& ctor_suffix = String::ZoneHandle(Symbols::Dot());
if (CurrentToken() == Token::kPERIOD) {
// Named constructor.
ConsumeToken();
@@ -2927,7 +2928,7 @@
// and contains a supercall in the initializer list.
String& ctor_name = String::ZoneHandle(
String::Concat(class_desc->class_name(),
- String::Handle(String::NewSymbol("."))));
+ String::Handle(Symbols::Dot())));
ctor_name = String::NewSymbol(ctor_name);
// The token position for the implicit constructor is the 'class'
// keyword of the constructor's class.
@@ -7856,7 +7857,7 @@
// for class 'A' is labeled 'A.C', and the static function implementing the
// unnamed constructor for class 'A' is labeled 'A.'.
// This convention prevents users from explicitly calling constructors.
- const String& period = String::Handle(String::NewSymbol("."));
+ const String& period = String::Handle(Symbols::Dot());
String& constructor_name =
String::Handle(String::Concat(type_class_name, period));
if (named_constructor != NULL) {

Powered by Google App Engine
This is Rietveld 408576698