Create frequently used symbols in the vm isolate

vm/exceptions.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/exceptions.h"
 
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/flags.h"
 #include "vm/object.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
+#include "vm/symbols.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, print_stacktrace_at_throw, false,
     "Prints a stack trace everytime a throw occurs.");
 
 
 const char* Exceptions::kCastExceptionDstName = "type cast";
 
 
@@ skipping 168 matching lines @@
   ASSERT(!caller.IsNull());
   const Class& caller_class = Class::Handle(caller.owner());
   return caller_class.script();
 }
 
 
 // Allocate a new instance of the given class name.
 // TODO(hausner): Rename this NewCoreInstance to call out the fact that
 // the class name is resolved in the core library implicitly?
 RawInstance* Exceptions::NewInstance(const char* class_name) {
-  const String& cls_name = String::Handle(String::NewSymbol(class_name));
+  const String& cls_name = String::Handle(Symbols::New(class_name));
   const Library& core_lib = Library::Handle(Library::CoreLibrary());
   Class& cls = Class::Handle(core_lib.LookupClass(cls_name));
   ASSERT(!cls.IsNull());
   // There are no parameterized error types, so no need to set type arguments.
   return Instance::New(cls);
 }
 
 
 // Assign the value to the field given by its name in the given instance.
 void Exceptions::SetField(const Instance& instance,
                           const Class& cls,
                           const char* field_name,
                           const Object& value) {
   const Field& field = Field::Handle(cls.LookupInstanceField(
-      String::Handle(String::NewSymbol(field_name))));
+      String::Handle(Symbols::New(field_name))));
   ASSERT(!field.IsNull());
   instance.SetField(field, value);
 }
 
 
 // Initialize the fields 'url', 'line', and 'column' in the given instance
 // according to the given token location in the given script.
 void Exceptions::SetLocationFields(const Instance& instance,
                                    const Class& cls,
                                    const Script& script,
@@ skipping 134 matching lines @@
 }
 
 
 RawObject* Exceptions::Create(
     ExceptionType type, const GrowableArray<const Object*>& arguments) {
   Library& library = Library::Handle();
   String& class_name = String::Handle();
   switch (type) {
     case kIndexOutOfRange:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("IndexOutOfRangeException");
+      class_name = Symbols::New("IndexOutOfRangeException");
       break;
     case kIllegalArgument:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("IllegalArgumentException");
+      class_name = Symbols::New("IllegalArgumentException");
       break;
     case kNoSuchMethod:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("NoSuchMethodException");
+      class_name = Symbols::New("NoSuchMethodException");
       break;
     case kClosureArgumentMismatch:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("ClosureArgumentMismatchException");
+      class_name = Symbols::New("ClosureArgumentMismatchException");
       break;
     case kObjectNotClosure:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("ObjectNotClosureException");
+      class_name = Symbols::New("ObjectNotClosureException");
       break;
     case kBadNumberFormat:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("BadNumberFormatException");
+      class_name = Symbols::New("BadNumberFormatException");
       break;
     case kStackOverflow:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("StackOverflowException");
+      class_name = Symbols::New("StackOverflowException");
       break;
     case kOutOfMemory:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("OutOfMemoryException");
+      class_name = Symbols::New("OutOfMemoryException");
       break;
     case kWrongArgumentCount:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("WrongArgumentCountException");
+      class_name = Symbols::New("WrongArgumentCountException");
       break;
     case kInternalError:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("InternalError");
+      class_name = Symbols::New("InternalError");
       break;
     case kNullPointer:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("NullPointerException");
+      class_name = Symbols::New("NullPointerException");
       break;
     case kIllegalJSRegExp:
       library = Library::CoreLibrary();
-      class_name = String::NewSymbol("IllegalJSRegExpException");
+      class_name = Symbols::New("IllegalJSRegExpException");
       break;
     case kIsolateSpawn:
       library = Library::IsolateLibrary();
-      class_name = String::NewSymbol("IsolateSpawnException");
+      class_name = Symbols::New("IsolateSpawnException");
       break;
   }
 
   return DartLibraryCalls::ExceptionCreate(library, class_name, arguments);
 }
 
 }  // namespace dart