Create frequently used symbols in the vm isolate

vm/code_generator_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
 
 #include "vm/ast.h"
 #include "vm/assembler.h"
 #include "vm/class_finalizer.h"
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/native_entry.h"
 #include "vm/native_entry_test.h"
+#include "vm/symbols.h"
 #include "vm/unit_test.h"
 #include "vm/virtual_memory.h"
 
 namespace dart {
 
 static const intptr_t kPos = Scanner::kDummyTokenIndex;
 
 
 // Helper to allocate and return a LocalVariable.
 static LocalVariable* NewTestLocalVariable(const char* name) {
-  const String& variable_name = String::ZoneHandle(String::NewSymbol(name));
+  const String& variable_name = String::ZoneHandle(Symbols::New(name));
   const Type& variable_type = Type::ZoneHandle(Type::DynamicType());
   return new LocalVariable(kPos, variable_name, variable_type);
 }
 
 
 CODEGEN_TEST_GENERATE(SimpleReturnCodegen, test) {
   test->node_sequence()->Add(new ReturnNode(kPos));
 }
 CODEGEN_TEST_RUN(SimpleReturnCodegen, Instance::null())
 
@@ skipping 174 matching lines @@
   local_scope->AddVariable(NewTestLocalVariable("b"));
   ASSERT(local_scope->num_variables() == num_params);
   const Array& default_values = Array::ZoneHandle(Array::New(num_opt_params));
   default_values.SetAt(0, Smi::ZoneHandle(Smi::New(1)));  // b = 1.
   test->set_default_parameter_values(default_values);
   const Function& function = test->function();
   function.set_num_fixed_parameters(num_fixed_params);
   function.set_num_optional_parameters(num_opt_params);
   const bool has_opt_params = true;
   const String& native_name =
-      String::ZoneHandle(String::NewSymbol("TestSmiSub"));
+      String::ZoneHandle(Symbols::New("TestSmiSub"));
   NativeFunction native_function =
       reinterpret_cast<NativeFunction>(NATIVE_ENTRY_FUNCTION(TestSmiSub));
   node_seq->Add(new ReturnNode(kPos,
                                new NativeBodyNode(kPos,
                                                   native_name,
                                                   native_function,
                                                   num_params,
                                                   has_opt_params,
                                                   false)));
 }
@@ skipping 24 matching lines @@
   SequenceNode* node_seq = test->node_sequence();
   LiteralNode* a =
       new LiteralNode(kPos, Double::ZoneHandle(Double::New(12.0, Heap::kOld)));
   UnaryOpNode* neg_node = new UnaryOpNode(kPos, Token::kSUB, a);
   node_seq->Add(new ReturnNode(kPos, neg_node));
 }
 CODEGEN_TEST_RUN(DoubleUnaryOpCodegen, Double::New(-12.0))
 
 
 static Library& MakeTestLibrary(const char* url) {
-  const String& lib_url = String::ZoneHandle(String::NewSymbol(url));
+  const String& lib_url = String::ZoneHandle(Symbols::New(url));
   Library& lib = Library::ZoneHandle(Library::New(lib_url));
   lib.Register();
   return lib;
 }
 
 
 static RawClass* LookupClass(const Library& lib, const char* name) {
-  const String& cls_name = String::ZoneHandle(String::NewSymbol(name));
+  const String& cls_name = String::ZoneHandle(Symbols::New(name));
   return lib.LookupClass(cls_name);
 }
 
 
 CODEGEN_TEST_GENERATE(StaticCallCodegen, test) {
   const char* kScriptChars =
       "class A {\n"
       "  static bar() { return 42; }\n"
       "  static fly() { return 5; }\n"
       "}\n";
@@ skipping 51 matching lines @@
   EXPECT(ClassFinalizer::FinalizePendingClasses());
   Class& cls = Class::ZoneHandle(LookupClass(lib, "A"));
   EXPECT(!cls.IsNull());
 
   String& constructor_name = String::Handle(String::New("A."));
   Function& constructor =
       Function::ZoneHandle(cls.LookupConstructor(constructor_name));
   EXPECT(!constructor.IsNull());
 
   // The unit test creates an instance of class A and calls function 'bar'.
-  String& function_bar_name = String::ZoneHandle(String::NewSymbol("bar"));
+  String& function_bar_name = String::ZoneHandle(Symbols::New("bar"));
   ArgumentListNode* no_arguments = new ArgumentListNode(kPos);
   const TypeArguments& no_type_arguments = TypeArguments::ZoneHandle();
   const LocalVariable& allocated = *test->CreateTempConstVariable("alloc");
   InstanceCallNode* call_bar = new InstanceCallNode(
       kPos,
       new ConstructorCallNode(
           kPos, no_type_arguments, constructor, no_arguments, allocated),
       function_bar_name,
       no_arguments);
 
@@ skipping 27 matching lines @@
   function.set_num_fixed_parameters(num_fixed_params);
   function.set_num_optional_parameters(num_opt_params);
   function.set_parameter_types(Array::Handle(Array::New(num_params)));
   function.set_parameter_names(Array::Handle(Array::New(num_params)));
   const Type& param_type = Type::Handle(Type::DynamicType());
   for (int i = 0; i < num_params - 1; i++) {
     function.SetParameterTypeAt(i, param_type);
   }
   const bool has_opt_params = true;
   const String& native_name =
-      String::ZoneHandle(String::NewSymbol("TestSmiSum"));
+      String::ZoneHandle(Symbols::New("TestSmiSum"));
   NativeFunction native_function =
       reinterpret_cast<NativeFunction>(NATIVE_ENTRY_FUNCTION(TestSmiSum));
   node_seq->Add(new ReturnNode(kPos,
                                new NativeBodyNode(kPos,
                                                   native_name,
                                                   native_function,
                                                   num_params,
                                                   has_opt_params,
                                                   false)));
 }
@@ skipping 91 matching lines @@
   EXPECT(!result.IsError());
   const GrowableObjectArray& libs =  GrowableObjectArray::Handle(
       Isolate::Current()->object_store()->libraries());
   ASSERT(!libs.IsNull());
   // App lib is the last one that was loaded.
   intptr_t num_libs = libs.Length();
   Library& app_lib = Library::Handle();
   app_lib ^= libs.At(num_libs - 1);
   ASSERT(!app_lib.IsNull());
   const Class& cls = Class::Handle(
-      app_lib.LookupClass(String::Handle(String::NewSymbol("A"))));
+      app_lib.LookupClass(String::Handle(Symbols::New("A"))));
   EXPECT_EQ(cls.raw(), result.clazz());
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32 || defined(TARGET_ARCH_X64)