Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 10783027: On Windows 8 when a metro app is snapped, all desktop applications receive a resize notification as… (Closed)

Created:
8 years, 5 months ago by ananta
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

On Windows 8 when a metro app is snapped, all desktop applications receive a resize notification as the work area is reduced. In Chrome the tabstrip paint would fail as the WM_GETTITLEBARINFOEX message fails to return the correct minimize offset. A fix went in to address this by caching the delta of the minimize button which is then applied to the corresponding client edge. This only addressed the case when the minimize button offset was returned as 0 from the WM_GETTITLEBARINFOEX message. At times this offset is negative. Fix is to check whether the minimize button offset is > 0 before applying the cached delta. BUG=135304 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
8 years, 5 months ago (2012-07-16 22:26:24 UTC) #1
sky
8 years, 5 months ago (2012-07-16 22:53:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698