Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 10783026: [Android] Additional fixes to build/common.gypi for Android. (Closed)

Created:
8 years, 5 months ago by Yaron
Modified:
8 years, 5 months ago
CC:
chromium-reviews, digit1, Steve Block
Base URL:
http://git.chromium.org/chromium/src.git@launcherssss
Visibility:
Public.

Description

[Android] Additional fixes to build/common.gypi for Android. Fixes: 1) disable_nacl 2) disable p2p_apis 3) Enable breakpad for official builds 4) Alpha-short use_system_icu 5) Enable .relro sections 6) Remove defunct android_unit_test_target_type flag BUG=137569 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M build/common.gypi View 6 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yaron
8 years, 5 months ago (2012-07-16 22:15:30 UTC) #1
Steve Block
lgtm Thanks!
8 years, 5 months ago (2012-07-17 09:06:09 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-17 18:36:48 UTC) #3
Yaron
jrg: ptal
8 years, 5 months ago (2012-07-17 18:37:46 UTC) #4
John Grabowski
LGTM
8 years, 5 months ago (2012-07-17 18:39:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10783026/1
8 years, 5 months ago (2012-07-17 18:44:27 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-17 20:45:49 UTC) #7
Change committed as 147088

Powered by Google App Engine
This is Rietveld 408576698