Add an activity monitor which profiles IO and CPU utilization.

Add an activity monitor which profiles IO and CPU utilization.

This consists of a simple native program which dumps /proc/diskstats and
/proc/stat to a file at a regular interval. The dump is then processed host-side
into a JSON format which is charted in HTML via the Google Charts API.

The perf test runners are not upstreamed yet and when they are this will be part
of the set of profilers available.

BUG=136690
TEST=manual, run activity_monitor.py to try out.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147019

[tonyg, 2012-07-16 17:35:01]

lgtm

[bulach, 2012-07-16 17:52:26]

I have a few comments below, mostly cleanup.. :)

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
File tools/android/activity_monitor/activity_monitor.cc (right):

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.cc:25: class ActivityMonitor {
nit: hmm... activity has a well defined and different meaning, I was expecting
this to monitor a given Activity, not the global io+cpu usage.. maybe
DeviceStatsMonitor?

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.cc:27: ActivityMonitor(const
std::string& out_path) :
nit: explicit

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.cc:29: samples_(),
nit: I think this is not needed..

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.cc:76: ActivityMonitor*
gActivityMonitor = NULL;
nit: g_activity_monitor

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.cc:104: signal(SIGTERM,
StopAndDumpStats);
uh, isn't the second param required to be a sighandler_t? not sure how this
works...

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
File tools/android/activity_monitor/activity_monitor.py (right):

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.py:23: from pylib import
android_commands
nit: while at it,
from pylib import constants

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.py:29:
os.path.dirname(os.path.realpath(__file__)), '..', '..', '..',
nit: pylib.constants.CHROME_DIR

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.py:38: def __init__(self,
adb=None, hz=20):
I just noticed that this is used by build/android/pylib/perf_test_runner too...
rather than create this circular dependency, please:

1. move the core bits and pieces (i.e., this class and the necessary constants)
to pylib/activity_monitor.py (or device_stats_monitor.py if you agree with the
comment above).

2. remove these evil default params (and fix up the imports / caller code from
perf_test_runner.py)

3. Keep just the "def main()" here...

The end goal being:

- pylib/activity_monitor.py provides a module / class.
- both perf_test_runner.py and this one depend cleanly on that.

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.py:112: def
ParseCpuStatsLine(line):
nit: add a _ prefix

https://chromiumcodereview.appspot.com/10783020/diff/1/tools/android/activity...
tools/android/activity_monitor/activity_monitor.py:115: CpuStats =
collections.namedtuple('CpuStats',
nit: cpu_stats

[Satish, 2012-07-17 14:49:02]

All review comments addressed, PTAL

[bulach, 2012-07-17 15:19:00]

lgtm, thanks!

[commit-bot: I haz the power, 2012-07-17 15:27:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satish@chromium.org/10783020/1007

[commit-bot: I haz the power, 2012-07-17 16:48:07]

Change committed as 147019

[Scott Hess - ex-Googler, 2012-07-17 18:16:00]

Satish,

http://build.chromium.org/p/chromium/builders/Linux/builds/27963/steps/check_...

build/android/pylib/device_stats_monitor.py: Has executable bit but not shebang

You on this?

[Scott Hess - ex-Googler, 2012-07-17 18:37:33]

On 2012/07/17 18:16:00, shess wrote:
> Satish,
> 
>
http://build.chromium.org/p/chromium/builders/Linux/builds/27963/steps/check_...
> 
> build/android/pylib/device_stats_monitor.py: Has executable bit but not
shebang
> 
> You on this?

http://src.chromium.org/viewvc/chrome?view=rev&revision=147050