Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10783007: Add rudimentary support in the ChromeFrame ActiveX to enable it work in a generic client site, i.e. (Closed)

Created:
8 years, 5 months ago by ananta
Modified:
8 years, 5 months ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield, grt (UTC plus 2)
Visibility:
Public.

Description

Add rudimentary support in the ChromeFrame ActiveX to enable it work in a generic client site, i.e. a non IE client site. Some of our users are creating apps which host ChromeFrame to render web pages. This enables them to use the chrome network stack by setting up a privileged chrome frame container and setting the corresponding properties on the ChromeFrame ActiveX. It mostly works well. However things like window.open break down as we need the ability in the ActiveX to be able to connect to an existing ExternalTabContainer instance. This works well in IE where the IWebBrowser implementation initiates the navigation correctly. However a generic implementation of the IWebBrowser interface does not do this. Fixes are to add a new function to the IChromeFramePrivileged interface which allows hosts to pass in the navigation url early in the lifetime of the ActiveX. In the ChromeFrame ActiveX we check if the url coming in is for an attach tab request and if so initiate the same. Fixes portions of bug https://code.google.com/p/chromium/issues/detail?id=137335 BUG=137335 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M chrome_frame/chrome_frame_activex.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 3 chunks +24 lines, -2 lines 0 comments Download
M chrome_frame/chrome_tab.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
8 years, 5 months ago (2012-07-13 23:51:05 UTC) #1
erikwright (departed)
8 years, 5 months ago (2012-07-17 14:07:53 UTC) #2
rubberstamp LGTM.

FYI grt/robertshield so you can understand it better upon your returns.

Powered by Google App Engine
This is Rietveld 408576698