Removing ENABLE_PROMO_RESOURCE_SERVICE guards

Removing ENABLE_PROMO_RESOURCE_SERVICE guards

They were introduced for Android (as it didn't support the promo
system).  Now all platforms support it, so the guards are removed.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147072

[aruslan, 2012-07-16 14:54:33]

ENABLE_PROMO_RESOURCE_SERVICE has served its goal, and now it's time to remove
it as we do not have builds with the guard disabled, so the code correctness is
not checked anyway.

[achuithb, 2012-07-17 14:44:37]

http://codereview.chromium.org/10783006/diff/8002/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (left):

http://codereview.chromium.org/10783006/diff/8002/chrome/common/pref_names.cc...
chrome/common/pref_names.cc:1452: const char kNtpCustomLogoStart[] =
"ntp.alt_logo_start";
I think these are deprecated. Could you add a TODO(achuith,aruslan) to delete
these?

[achuithb, 2012-07-17 14:45:34]

Is there no pertinent bug for this? Please update BUG= in the description.

lgtm otherwise. Thanks!

[aruslan, 2012-07-17 16:08:51]

Added TODO; committing.

https://chromiumcodereview.appspot.com/10783006/diff/8002/chrome/common/pref_...
File chrome/common/pref_names.cc (left):

https://chromiumcodereview.appspot.com/10783006/diff/8002/chrome/common/pref_...
chrome/common/pref_names.cc:1452: const char kNtpCustomLogoStart[] =
"ntp.alt_logo_start";
On 2012/07/17 14:44:38, achuith.bhandarkar wrote:
> I think these are deprecated. Could you add a TODO(achuith,aruslan) to delete
> these?

Done.

[commit-bot: I haz the power, 2012-07-17 16:09:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aruslan@chromium.org/10783006/3002

[commit-bot: I haz the power, 2012-07-17 16:09:53]

Presubmit check for 10783006-3002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui/ntp
    chrome/browser/profiles

[aruslan, 2012-07-17 16:12:57]

Hi Miranda, Dan -- could you please review the #if defined removal?

[Miranda Callahan, 2012-07-17 16:39:39]

On 2012/07/17 16:12:57, aruslan wrote:
> Hi Miranda, Dan -- could you please review the #if defined removal?

profiles/* LGTM!

[Dan Beam, 2012-07-17 17:06:37]

chrome/browser/ui/webui/ntp lgtm

[commit-bot: I haz the power, 2012-07-17 17:07:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aruslan@chromium.org/10783006/3002

[commit-bot: I haz the power, 2012-07-17 19:43:09]

Change committed as 147072