Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 10782033: Removed CopyAppendForeignDescriptor. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Removed CopyAppendForeignDescriptor. Use descriptor array preallocation + appending instead. Committed: https://code.google.com/p/v8/source/detail?r=12133

Patch Set 1 #

Patch Set 2 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -161 lines) Patch
M src/bootstrapper.cc View 4 chunks +143 lines, -126 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL.
8 years, 5 months ago (2012-07-17 15:02:05 UTC) #1
Jakob Kummerow
8 years, 5 months ago (2012-07-18 13:36:35 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698