Add content pack information to Extension.

Add content pack information to Extension.


BUG=141842
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175506

[Bernhard Bauer, 2012-08-13 22:29:13]

Hey Antony, 

could you take look at this CL? I hope it doesn't look too horrible ;-)

If we're worried about proliferation of non-extension extensions, maybe it would
actually make sense to add a new abstraction of "installable/updatable package"?
I vaguely remember plans of that nature for updating internal components like
the bundled Flash Player…

[asargent_no_longer_on_chrome, 2012-08-14 00:21:02]

I'll try and look at this in more detail tonight, but an initial answer to your
question: we do indeed have a way to update our flash independent of chrome
builds themselves, using some of the infrastructure code from extensions. 

You'll see that in

chrome/browser/component_updater

Have a quick look and see if the component_updater stuff seeems like a good fit
or not for your purposes.

[asargent_no_longer_on_chrome, 2012-08-14 20:47:25]

+aa for his thoughts. 

After looking at this I'm a little wary of having this become another extension
type, because "a packaged up list of urls" is pretty different from an
extension/app. 

Are these something that you're envisioning people can install from the
webstore?

[Bernhard Bauer, 2012-08-14 22:50:45]

On 2012/08/14 20:47:25, Antony Sargent wrote:
> +aa for his thoughts. 
> 
> After looking at this I'm a little wary of having this become another
extension
> type, because "a packaged up list of urls" is pretty different from an
> extension/app. 
> 
> Are these something that you're envisioning people can install from the
> webstore?

Yes. We want for people to be able to install them via all available extension
installation mechanisms, and for content publishers to be able to publish them
easily, also via the Web Store.

Like I mentioned earlier, there is already precedent for these kinds of
extensions-but-not-quite-extensions with themes. Maybe it would make sense to
abstract them to some sort of notion of an installable package, of which an
actual extension would be a subclass?

[asargent_no_longer_on_chrome, 2012-08-15 00:16:45]

On 2012/08/14 22:50:45, Bernhard Bauer wrote:
> On 2012/08/14 20:47:25, Antony Sargent wrote:
> > +aa for his thoughts. 
> > 
> > After looking at this I'm a little wary of having this become another
> extension
> > type, because "a packaged up list of urls" is pretty different from an
> > extension/app. 
> > 
> > Are these something that you're envisioning people can install from the
> > webstore?
> 
> Yes. We want for people to be able to install them via all available extension
> installation mechanisms, and for content publishers to be able to publish them
> easily, also via the Web Store.
> 
> Like I mentioned earlier, there is already precedent for these kinds of
> extensions-but-not-quite-extensions with themes. Maybe it would make sense to
> abstract them to some sort of notion of an installable package, of which an
> actual extension would be a subclass?

Yes, I think it would make sense to build that abstraction - there are a lot of
places where code dealing with Extension objects is really complicated by us
overloading them with different semantics. I'll defer to Aaron for the rest of
this review (I'm heading out for 3 days of vacation).

[Aaron Boodman, 2012-08-15 04:05:18]

This is a change in direction from last time we talked about Playpen. Please
hold off landing things in this direction until we can talk it over.

http://codereview.chromium.org/10782030/diff/18001/chrome/common/extensions/e...
File chrome/common/extensions/extension.h (right):

http://codereview.chromium.org/10782030/diff/18001/chrome/common/extensions/e...
chrome/common/extensions/extension.h:715: FilePath GetContentPackSiteList()
const;
Seems like this should be an ExtensionResource.

http://codereview.chromium.org/10782030/diff/18001/chrome/common/extensions/e...
chrome/common/extensions/extension.h:870: // Helper function for implementing
HasCachedImage/GetCachedImage. A return
Insert newline.

[Bernhard Bauer, 2012-08-15 19:35:09]

http://codereview.chromium.org/10782030/diff/18001/chrome/common/extensions/e...
File chrome/common/extensions/extension.h (right):

http://codereview.chromium.org/10782030/diff/18001/chrome/common/extensions/e...
chrome/common/extensions/extension.h:715: FilePath GetContentPackSiteList()
const;
On 2012/08/15 04:05:18, Aaron Boodman wrote:
> Seems like this should be an ExtensionResource.

Done.

http://codereview.chromium.org/10782030/diff/18001/chrome/common/extensions/e...
chrome/common/extensions/extension.h:870: // Helper function for implementing
HasCachedImage/GetCachedImage. A return
On 2012/08/15 04:05:18, Aaron Boodman wrote:
> Insert newline.

Done.

[Bernhard Bauer, 2012-08-21 14:01:44]

After discussion on the design document, updated the CL to just add a new
feature on Extension.

[Bernhard Bauer, 2012-11-06 19:01:32]

Trying to revive this CL, Aaron, could you take a look?

[Bernhard Bauer, 2012-11-07 21:31:59]

On 2012/11/06 19:01:32, Bernhard Bauer wrote:
> Trying to revive this CL, Aaron, could you take a look?

Aaron, ping? :)

[Bernhard Bauer, 2012-11-13 17:50:35]

Antony, could you review this CL? Aaron seems to be busy.

Aaron, I'm happy to discuss any objections you have :)

[Bernhard Bauer, 2013-01-03 17:45:15]

Hi Matt, 

could you take a look at this CL? Thanks! :)

[Matt Perry, 2013-01-04 20:17:03]

On 2013/01/03 17:45:15, Bernhard Bauer wrote:
> Hi Matt, 
> 
> could you take a look at this CL? Thanks! :)

OK, taking a look. I'm brushing up on the design doc first.

[Matt Perry, 2013-01-07 21:26:36]

lgtm

[commit-bot: I haz the power, 2013-01-07 21:28:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/10782030/39001

[commit-bot: I haz the power, 2013-01-08 00:00:05]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-08 08:37:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/10782030/39001

[commit-bot: I haz the power, 2013-01-08 09:09:16]

Change committed as 175506