Issue 10782026: Always fix up the enumeration indices when turning to fast mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10782026: Always fix up the enumeration indices when turning to fast mode. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Always fix up the enumeration indices when turning to fast mode. Committed: https://code.google.com/p/v8/source/detail?r=12102

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -21 lines)			Patch
	M	src/objects.cc	View		5 chunks	+11 lines, -21 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danno

8 years, 5 months ago (2012-07-17 09:55:02 UTC) #2

LGTM with nit.

https://chromiumcodereview.appspot.com/10782026/diff/1/src/objects.cc
File src/objects.cc (left):

https://chromiumcodereview.appspot.com/10782026/diff/1/src/objects.cc#oldcode...
src/objects.cc:12479: NextEnumerationIndex() +
nit: put this on previous line, adjust spacing below as appropriate.

Expand Messages | Collapse Messages