Issue 10782019: Unbreak video_decode_accelerator_unittest by restoring HasMoreRBSPData().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10782019: Unbreak video_decode_accelerator_unittest by restoring HasMoreRBSPData(). (Closed)

Created:
8 years, 5 months ago by Ami GONE FROM CHROMIUM

Modified:
8 years, 5 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org, Pawel Osciak, xiaomings

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Unbreak video_decode_accelerator_unittest by restoring HasMoreRBSPData(). r145769 broke the default test-25fps.h264 test stream by replacing a call to HasMoreRBSPData() with a call to HasMoreData(). This CL restores HasMoreRBSPData() from the grave and calls it again. TBR=acolwell@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146893

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -1 line)			Patch
M	content/common/gpu/media/h264_bit_reader.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/common/gpu/media/h264_bit_reader.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	content/common/gpu/media/h264_parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

xiaomings/posciak: FYI acolwell: please review when you get back (I'm going to TBR this in ...

8 years, 5 months ago (2012-07-16 20:02:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10782019/1

8 years, 5 months ago (2012-07-16 20:02:44 UTC) #2

Change committed as 146893

Expand Messages | Collapse Messages