Set 'gcc_version' to 0 for Clang/ASan/TSan builds.

Set 'gcc_version' to 0 for Clang/ASan/TSan builds.

BUG=137480
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147022

[Craig, 2012-07-16 15:33:07]

( heading out into traffic now so will probably only be able to LGTM this later
when I'm back on the 'net )

https://chromiumcodereview.appspot.com/10782014/diff/10001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10782014/diff/10001/build/common.gypi#...
build/common.gypi:514: ['asan==1 or tsan==1', {
There's other stuff around line 1140 that sets clang to 1 too. Can that be
killed off?

https://chromiumcodereview.appspot.com/10782014/diff/10001/build/common.gypi#...
build/common.gypi:854: # This is used to tweak build flags for gcc 4.4.
This appears only to be used in one spot for gcc 4.5 these days. Can you change
the comment to say 4.5 please?

[Alexander Potapenko, 2012-07-16 15:39:29]

https://chromiumcodereview.appspot.com/10782014/diff/10001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10782014/diff/10001/build/common.gypi#...
build/common.gypi:514: ['asan==1 or tsan==1', {
On 2012/07/16 15:33:07, Craig wrote:
> There's other stuff around line 1140 that sets clang to 1 too. Can that be
> killed off?
I'm trying to do so, but undefined variables appear from different places. I'll
get back to this tomorrow.

[Alexander Potapenko, 2012-07-17 12:53:12]

Please take another look.
I've decided not to mess around with GYP flag implication in this CL -- is this
fine?

[Craig, 2012-07-17 15:39:15]

On 2012/07/17 12:53:12, Alexander Potapenko wrote:
> Please take another look.
> I've decided not to mess around with GYP flag implication in this CL -- is
this
> fine?

LGTM

[commit-bot: I haz the power, 2012-07-17 15:40:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/10782014/12002

[commit-bot: I haz the power, 2012-07-17 17:00:22]

Change committed as 147022