Make audio volume icon HDC

Make audio volume icon HDC
Update the image for 2x which only had 4 icons
Show mute icon when volume is 0 (+ some simplification)

BUG=122992, 137763
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148089

[pkotwicz, 2012-07-16 18:49:24]

lgtm

[oshima, 2012-07-24 00:14:38]

On 2012/07/24 00:13:44, oshima wrote:

Dan, I updated the CL to include the fix for 137763. PTL.

[Daniel Erat, 2012-07-24 00:24:33]

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
File ash/system/audio/tray_volume.cc (right):

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
ash/system/audio/tray_volume.cc:37: const int kVolumeLevel = 4;
nit: Add a comment describing what this represents.  Number of non-zero image
indices?

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
ash/system/audio/tray_volume.cc:60: 0 : std::ceil(delegate->GetVolumeLevel() *
kVolumeLevel);
Not your fault, but do you mind updating ash/system/tray/system_tray_delegate.h
to document whether the level is in the range [0, 100] or [0, 1]?  I'm guessing
from this code that it's the latter, but I hate seeing this stuff be
undocumented.

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
ash/system/audio/tray_volume.cc:60: 0 : std::ceil(delegate->GetVolumeLevel() *
kVolumeLevel);
The old code looks like it used kVolumeLevel - 1 for the maximum level, but this
appears to be using kVolumeLevel instead.  Intentional?

[oshima, 2012-07-24 00:44:20]

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
File ash/system/audio/tray_volume.cc (right):

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
ash/system/audio/tray_volume.cc:37: const int kVolumeLevel = 4;
On 2012/07/24 00:24:33, Daniel Erat wrote:
> nit: Add a comment describing what this represents.  Number of non-zero image
> indices?

Done.

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
ash/system/audio/tray_volume.cc:60: 0 : std::ceil(delegate->GetVolumeLevel() *
kVolumeLevel);
On 2012/07/24 00:24:33, Daniel Erat wrote:
> Not your fault, but do you mind updating
ash/system/tray/system_tray_delegate.h
> to document whether the level is in the range [0, 100] or [0, 1]?  I'm
guessing
> from this code that it's the latter, but I hate seeing this stuff be
> undocumented.

Done.

http://codereview.chromium.org/10781021/diff/10001/ash/system/audio/tray_volu...
ash/system/audio/tray_volume.cc:60: 0 : std::ceil(delegate->GetVolumeLevel() *
kVolumeLevel);
On 2012/07/24 00:24:33, Daniel Erat wrote:
> The old code looks like it used kVolumeLevel - 1 for the maximum level, but
this
> appears to be using kVolumeLevel instead.  Intentional?

overlooked original behavior. Fixed.

[Daniel Erat, 2012-07-24 00:50:09]

LGTM w/nits

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
File ash/system/audio/tray_volume.cc (right):

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
ash/system/audio/tray_volume.cc:38: // IDR_AURA_UBER_TRAY_VOLUME_LEVELS contains
5 images,
nit: "... contains 5 images.  The one for mute is at the 0 index and the other
four are used for ascending volume levels."

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
ash/system/audio/tray_volume.cc:41: const int kVolumeLevel = 4;
nit: rename to kVolumeLevels?

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
ash/system/audio/tray_volume.cc:66: kVolumeLevel : std::ceil(level *
(kVolumeLevel -1)));
nit: space between "-" and "1"

[oshima, 2012-07-24 11:34:33]

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
File ash/system/audio/tray_volume.cc (right):

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
ash/system/audio/tray_volume.cc:38: // IDR_AURA_UBER_TRAY_VOLUME_LEVELS contains
5 images,
On 2012/07/24 00:50:10, Daniel Erat wrote:
> nit: "... contains 5 images.  The one for mute is at the 0 index and the other
> four are used for ascending volume levels."

Done.

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
ash/system/audio/tray_volume.cc:41: const int kVolumeLevel = 4;
On 2012/07/24 00:50:10, Daniel Erat wrote:
> nit: rename to kVolumeLevels?

Done.

http://codereview.chromium.org/10781021/diff/7002/ash/system/audio/tray_volum...
ash/system/audio/tray_volume.cc:66: kVolumeLevel : std::ceil(level *
(kVolumeLevel -1)));
On 2012/07/24 00:50:10, Daniel Erat wrote:
> nit: space between "-" and "1"

Done.