Isolated FS for media devices.

webkit/fileapi/media/media_device_map_service.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/fileapi/media/media_device_map_service.h"
+
+#include <utility>
+
+#include "base/message_loop.h"
+
+namespace fileapi {
+
+using base::SequencedTaskRunner;
+
+// static
+MediaDeviceMapService* MediaDeviceMapService::GetInstance() {
+  return Singleton<MediaDeviceMapService>::get();
+}
+
+void MediaDeviceMapService::AddMediaDevice(
+    const FilePath::StringType& device_id,
+    SequencedTaskRunner* media_task_runner) {
+  DCHECK(media_task_runner);
+
+  base::AutoLock lock(media_device_map_lock_);
+  MediaDeviceMap::const_iterator it = media_device_map_.find(device_id);
+  if (it == media_device_map_.end()) {
+    media_device_map_.insert(std::make_pair(
+        device_id, new MediaDeviceInterfaceImpl(device_id, media_task_runner)));
+  }
+}
+
+void MediaDeviceMapService::RemoveMediaDevice(
+    const FilePath::StringType& device_id) {
+  base::AutoLock lock(media_device_map_lock_);
+  MediaDeviceMap::iterator it = media_device_map_.find(device_id);
+  if (it != media_device_map_.end())
+    media_device_map_.erase(it);
+}
+
+bool MediaDeviceMapService::GetMediaDevice(
+    const FilePath::StringType& device_id,
+    MediaDeviceInterfaceImpl* device) {
+  base::AutoLock lock(media_device_map_lock_);
+  MediaDeviceMap::iterator it = media_device_map_.find(device_id);
+  if (it == media_device_map_.end())
+    return false;
+  device = it->second.get();
+  return true;

[kinuko, 2012/07/31 05:35:44]

I think this could also just return MediaDeviceInterfaceImpl instead of boolean
since this basically looks to be a simple getter.  Then the callsite doesn't
need to check both the return value and the out device ptr. (And the latest
patch doesn't seem to check the return value either)

[kmadhusu, 2012/07/31 19:47:24]

Done.

+}
+
+MediaDeviceMapService::MediaDeviceMapService() {
+}
+
+MediaDeviceMapService::~MediaDeviceMapService() {
+}
+
+}  // namespace fileapi