Isolated FS for media devices.

webkit/fileapi/media/device_media_file_util.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/fileapi/media/device_media_file_util.h"
+
+#include "base/message_loop_proxy.h"
+#include "base/file_util.h"
+#include "base/memory/scoped_ptr.h"
+#include "webkit/blob/shareable_file_reference.h"
+#include "webkit/fileapi/file_system_operation_context.h"
+#include "webkit/fileapi/file_system_url.h"
+#include "webkit/fileapi/isolated_context.h"
+#include "webkit/fileapi/media/media_device_map_service.h"
+#include "webkit/fileapi/media/media_device_interface_impl.h"
+
+using base::PlatformFileError;
+using base::PlatformFileInfo;
+using webkit_blob::ShareableFileReference;
+
+namespace fileapi {
+
+namespace {
+
+const FilePath::CharType kIsolatedMediaFileSystemDir[] =

[kinuko, 2012/07/31 05:35:44]

nit: Similarly kIsolatedMediaFileSystemDir should be probably
kDeviceMediaFileSystemDir?  Or since it's file-local simply 'kFileUtilTempDir'
or something might be ok.

[kmadhusu, 2012/07/31 19:47:24]

kIsolatedMediaFileSystemDir -> kDeviceMediaFileUtilTempDir

+    FILE_PATH_LITERAL("DeviceMediaFileSystem");
+
+}  // namespace
+
+DeviceMediaFileUtil::DeviceMediaFileUtil(const FilePath& profile_path)
+    : profile_path_(profile_path) {
+}
+
+PlatformFileError DeviceMediaFileUtil::CreateOrOpen(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url, int file_flags,
+    PlatformFile* file_handle, bool* created) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::Close(
+    FileSystemOperationContext* context,
+    PlatformFile file_handle) {
+  // We don't allow open thus Close won't be called.
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::EnsureFileExists(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url,
+    bool* created) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::CreateDirectory(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url,
+    bool exclusive,
+    bool recursive) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::GetFileInfo(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url,
+    PlatformFileInfo* file_info,
+    FilePath* platform_path) {
+  scoped_refptr<MediaDeviceInterfaceImpl> device(context->media_device());

[kinuko, 2012/07/31 05:35:44]

nit: to make sure: since now we keep a ref in OperationContext we can safely use
the rawptr as is, i.e. code like following would be also safe (and simpler):

DCHECK(context->media_device());
return context->media_device()->GetFileInfo(url.path(), file_info);

[kmadhusu, 2012/07/31 19:47:24]

Done.

+  DCHECK(device.get());
+  return device->GetFileInfo(url.path(), file_info);
+}
+
+FileSystemFileUtil::AbstractFileEnumerator*
+DeviceMediaFileUtil::CreateFileEnumerator(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url,
+    bool recursive) {
+  scoped_refptr<MediaDeviceInterfaceImpl> device(context->media_device());
+  DCHECK(device.get());
+  return device->CreateFileEnumerator(url.path(), recursive);
+}
+
+PlatformFileError DeviceMediaFileUtil::GetLocalFilePath(
+    FileSystemOperationContext* context,
+    const FileSystemURL& file_system_url,
+    FilePath* local_file_path) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::Touch(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url,
+    const base::Time& last_access_time,
+    const base::Time& last_modified_time) {
+  scoped_refptr<MediaDeviceInterfaceImpl> device(context->media_device());
+  DCHECK(device.get());
+  return device->Touch(url.path(), last_access_time, last_modified_time);
+}
+
+PlatformFileError DeviceMediaFileUtil::Truncate(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url,
+    int64 length) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+bool DeviceMediaFileUtil::PathExists(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url) {
+  scoped_refptr<MediaDeviceInterfaceImpl> device(context->media_device());
+  DCHECK(device.get());
+  return device->PathExists(url.path());
+}
+
+bool DeviceMediaFileUtil::DirectoryExists(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url) {
+  scoped_refptr<MediaDeviceInterfaceImpl> device(context->media_device());
+  DCHECK(device.get());
+  return device->DirectoryExists(url.path());
+}
+
+bool DeviceMediaFileUtil::IsDirectoryEmpty(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url) {
+  scoped_refptr<MediaDeviceInterfaceImpl> device(context->media_device());
+  DCHECK(device.get());
+  return device->IsDirectoryEmpty(url.path());
+}
+
+PlatformFileError DeviceMediaFileUtil::CopyOrMoveFile(
+    FileSystemOperationContext* context,
+    const FileSystemURL& src_url,
+    const FileSystemURL& dest_url,
+    bool copy) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::CopyInForeignFile(
+    FileSystemOperationContext* context,
+    const FilePath& src_file_path,
+    const FileSystemURL& dest_url) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::DeleteFile(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+PlatformFileError DeviceMediaFileUtil::DeleteSingleDirectory(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url) {
+  return base::PLATFORM_FILE_ERROR_SECURITY;
+}
+
+scoped_refptr<ShareableFileReference> DeviceMediaFileUtil::CreateSnapshotFile(
+    FileSystemOperationContext* context,
+    const FileSystemURL& url,
+    base::PlatformFileError* result,
+    base::PlatformFileInfo* file_info,
+    FilePath* local_path) {
+  DCHECK(result);
+  DCHECK(file_info);
+  DCHECK(local_path);
+
+  scoped_refptr<ShareableFileReference> file_ref;
+  *result = base::PLATFORM_FILE_ERROR_INVALID_URL;

[kinuko, 2012/07/31 05:35:44]

nit: maybe we can simply initialize this to PLATFORM_FILE_ERROR_FAILED and
remove line 181 and 189?

[kmadhusu, 2012/07/31 19:47:24]

Done.

+
+  scoped_refptr<MediaDeviceInterfaceImpl> device(context->media_device());
+  DCHECK(device.get());
+
+  // Create a temp file in "profile_path_/kIsolatedMediaFileSystemDir".
+  FilePath isolated_media_file_system_dir_path =
+      profile_path_.Append(kIsolatedMediaFileSystemDir);
+  bool dir_exists = file_util::DirectoryExists(
+      isolated_media_file_system_dir_path);
+  if (!dir_exists) {
+    if (!file_util::CreateDirectory(isolated_media_file_system_dir_path)) {
+      *result = base::PLATFORM_FILE_ERROR_FAILED;
+      return file_ref;
+    }
+  }
+
+  bool file_created = file_util::CreateTemporaryFileInDir(
+      isolated_media_file_system_dir_path, local_path);
+  if (!file_created) {
+    *result = base::PLATFORM_FILE_ERROR_FAILED;
+    return file_ref;
+  }
+
+  if (device->CreateSnapshotFile(url.path(), *local_path, file_info))

[kinuko, 2012/07/31 05:35:44]

I think you've changed this method to return PlatformFileError, therefore this
code should be:

*result = device->CreateSnapshotFile(...)

?

[kmadhusu, 2012/07/31 19:47:24]

Fixed.

+    *result = base::PLATFORM_FILE_OK;
+
+  if (*result == base::PLATFORM_FILE_OK) {
+    file_ref = ShareableFileReference::GetOrCreate(
+                   *local_path,
+                   ShareableFileReference::DELETE_ON_FINAL_RELEASE,
+                   context->file_task_runner());
+  }
+  return file_ref;
+}
+
+}  // namespace fileapi