Issue 10781011: Fix ICs for slow objects with native accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10781011: Fix ICs for slow objects with native accessor. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger

Modified:
8 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix ICs for slow objects with native accessor. This prevents creation of LoadICs or StoreICs for native callbacks on objects in dictionary mode. Those ICs fail if the accessor is installed on the receiver itself and also lead to bogus type feedback. R=danno@chromium.org BUG=chromium:137002 TEST=test/test-api/Regress137002[a,b] Committed: https://code.google.com/p/v8/source/detail?r=12088

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	src/ic.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages