Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Side by Side Diff: src/api.cc

Issue 10780031: Grouping all map creation code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3216 matching lines...) Expand 10 before | Expand all | Expand 10 after
3227 ON_BAILOUT(isolate, "v8::Object::TurnOnAccessCheck()", return); 3227 ON_BAILOUT(isolate, "v8::Object::TurnOnAccessCheck()", return);
3228 ENTER_V8(isolate); 3228 ENTER_V8(isolate);
3229 i::HandleScope scope(isolate); 3229 i::HandleScope scope(isolate);
3230 i::Handle<i::JSObject> obj = Utils::OpenHandle(this); 3230 i::Handle<i::JSObject> obj = Utils::OpenHandle(this);
3231 3231
3232 // When turning on access checks for a global object deoptimize all functions 3232 // When turning on access checks for a global object deoptimize all functions
3233 // as optimized code does not always handle access checks. 3233 // as optimized code does not always handle access checks.
3234 i::Deoptimizer::DeoptimizeGlobalObject(*obj); 3234 i::Deoptimizer::DeoptimizeGlobalObject(*obj);
3235 3235
3236 i::Handle<i::Map> new_map = 3236 i::Handle<i::Map> new_map =
3237 isolate->factory()->CopyMapDropTransitions(i::Handle<i::Map>(obj->map())); 3237 isolate->factory()->CopyMap(i::Handle<i::Map>(obj->map()));
3238 new_map->set_is_access_check_needed(true); 3238 new_map->set_is_access_check_needed(true);
3239 obj->set_map(*new_map); 3239 obj->set_map(*new_map);
3240 } 3240 }
3241 3241
3242 3242
3243 bool v8::Object::IsDirty() { 3243 bool v8::Object::IsDirty() {
3244 return Utils::OpenHandle(this)->IsDirty(); 3244 return Utils::OpenHandle(this)->IsDirty();
3245 } 3245 }
3246 3246
3247 3247
(...skipping 3270 matching lines...) Expand 10 before | Expand all | Expand 10 after
6518 6518
6519 v->VisitPointers(blocks_.first(), first_block_limit_); 6519 v->VisitPointers(blocks_.first(), first_block_limit_);
6520 6520
6521 for (int i = 1; i < blocks_.length(); i++) { 6521 for (int i = 1; i < blocks_.length(); i++) {
6522 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6522 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6523 } 6523 }
6524 } 6524 }
6525 6525
6526 6526
6527 } } // namespace v8::internal 6527 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698