Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10780027: JSON schema compiler: Read the "optional" property out of the JSON for Function. (Closed)

Created:
8 years, 5 months ago by not at google - send to devlin
Modified:
8 years, 5 months ago
Reviewers:
Matt Tytel
CC:
chromium-reviews, pam+watch_chromium.org, benwells, koz (OOO until 15th September), cduvall, chebert
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

JSON schema compiler: Read the "optional" property out of the JSON for Function. Without this, code that looks for the "callback" in a Function, and is interested in whether it's optional (e.g. the new docs server) won't work. TBR=mtytel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/json_schema_compiler/model.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
This makes the new docs server work again.
8 years, 5 months ago (2012-07-17 03:06:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10780027/1
8 years, 5 months ago (2012-07-17 03:07:02 UTC) #2
Matt Tytel
Yup yup. LGTM.
8 years, 5 months ago (2012-07-17 03:38:21 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-17 06:33:31 UTC) #4
Change committed as 146957

Powered by Google App Engine
This is Rietveld 408576698