Change base::SystemMonitor's media device functions to take a type and string16 instead of a FilePa…

chrome/browser/media_gallery/media_device_notifications_window_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_gallery/media_device_notifications_window_win.h"
 
 #include <windows.h>
 #include <dbt.h>
 
 #include <string>
 
 #include "base/file_path.h"
-#include "base/sys_string_conversions.h"
+#include "base/string_number_conversions.h"
 #include "base/system_monitor/system_monitor.h"
 #include "base/win/wrapped_window_proc.h"
 #include "chrome/browser/media_gallery/media_device_notifications_utils.h"
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserThread;
 
 namespace {
 
 const wchar_t WindowClassName[] = L"Chrome_MediaDeviceNotificationWindow";
@@ skipping 71 matching lines @@
       DWORD unitmask = GetVolumeBitMaskFromBroadcastHeader(data);
       for (int i = 0; unitmask; ++i, unitmask >>= 1) {
         if (unitmask & 0x01) {
           FilePath::StringType drive(L"_:\\");
           drive[0] = L'A' + i;
           WCHAR volume_name[MAX_PATH + 1];
           if ((*volume_name_func_)(drive.c_str(), volume_name, MAX_PATH + 1)) {
             BrowserThread::PostTask(
                 BrowserThread::FILE, FROM_HERE,
                 base::Bind(&MediaDeviceNotificationsWindowWin::
-                    CheckDeviceTypeOnFileThread, this, i,
+                    CheckDeviceTypeOnFileThread, this, base::IntToString(i),

[vandebo (ex-Chrome), 2012/07/20 00:27:41]

nit: Pass drive instead of IntToString(i) ?

[Lei Zhang, 2012/07/20 00:46:25]

Meh. If we do then we need to reconstruct |drive| in the detach code below too.
We need to rewrite this soon anyway so the IDs are unique.

                     FilePath::StringType(volume_name), FilePath(drive)));
           }
         }
       }
       break;
     }
     case DBT_DEVICEREMOVECOMPLETE: {
       DWORD unitmask = GetVolumeBitMaskFromBroadcastHeader(data);
       for (int i = 0; unitmask; ++i, unitmask >>= 1) {
         if (unitmask & 0x01) {
           base::SystemMonitor* monitor = base::SystemMonitor::Get();
           monitor->ProcessMediaDeviceDetached(i);
         }
       }
       break;
     }
   }
   return TRUE;
 }
 
 void MediaDeviceNotificationsWindowWin::CheckDeviceTypeOnFileThread(
-    unsigned int id,
+    const std::string& id,
     const FilePath::StringType& device_name,
     const FilePath& path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   if (!IsMediaDevice(path.value()))
     return;
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(
           &MediaDeviceNotificationsWindowWin::
               ProcessMediaDeviceAttachedOnUIThread,
           this, id, device_name, path));
 }
 
 void MediaDeviceNotificationsWindowWin::ProcessMediaDeviceAttachedOnUIThread(
-    unsigned int id,
+    const std::string& id,
     const FilePath::StringType& device_name,
     const FilePath& path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  const std::string device_name_utf8(base::SysWideToUTF8(device_name));
   base::SystemMonitor* monitor = base::SystemMonitor::Get();
-  monitor->ProcessMediaDeviceAttached(id, device_name_utf8, path);
+  monitor->ProcessMediaDeviceAttached(id,
+                                      device_name,
+                                      base::SystemMonitor::TYPE_PATH,
+                                      path.value());
 }
 
 LRESULT CALLBACK MediaDeviceNotificationsWindowWin::WndProc(
     HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam) {
   switch (message) {
     case WM_DEVICECHANGE:
       return OnDeviceChange(static_cast<UINT>(wparam),
                             static_cast<DWORD>(lparam));
     default:
       break;
@@ skipping 10 matching lines @@
     LPARAM lparam) {
   MediaDeviceNotificationsWindowWin* msg_wnd =
       reinterpret_cast<MediaDeviceNotificationsWindowWin*>(
           GetWindowLongPtr(hwnd, GWLP_USERDATA));
   if (msg_wnd)
     return msg_wnd->WndProc(hwnd, message, wparam, lparam);
   return ::DefWindowProc(hwnd, message, wparam, lparam);
 }
 
 }  // namespace chrome