Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 10780012: Minor issue with the org.freedesktop.PowerManagement UnInhibit method call (Closed)

Created:
8 years, 5 months ago by cristian.patrasciuc
Modified:
8 years, 5 months ago
Reviewers:
Mike Mammarella, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

A small defect was introduced with the refactoring of this file. The freedesktop method for uninhibit is called with a wrong name, giving this type of errors on KDE: [22381:22390:37538866338:ERROR:power_save_blocker_linux.cc(289)] No response to Uninhibit() request! BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/power_save_blocker_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
cristian.patrasciuc
8 years, 5 months ago (2012-07-15 20:56:40 UTC) #1
Mike Mammarella
LGTM thanks, after you commit I will merge to affected branches On Jul 15, 2012 ...
8 years, 5 months ago (2012-07-15 22:23:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cristian.patrasciuc@gmail.com/10780012/1
8 years, 5 months ago (2012-07-16 06:32:58 UTC) #3
commit-bot: I haz the power
Presubmit check for 10780012-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-16 06:33:00 UTC) #4
cristian.patrasciuc
Adding sky since I need LGTM from an owner.
8 years, 5 months ago (2012-07-16 06:37:59 UTC) #5
sky
LGTM
8 years, 5 months ago (2012-07-16 14:10:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cristian.patrasciuc@gmail.com/10780012/1
8 years, 5 months ago (2012-07-16 15:52:25 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-16 17:20:57 UTC) #8
Change committed as 146819

Powered by Google App Engine
This is Rietveld 408576698