Issue 10780002: Revert "Revert 146262 - Revert "Revert 142517 - [Sync] Refactor sync configuration logic.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10780002: Revert "Revert 146262 - Revert "Revert 142517 - [Sync] Refactor sync configuration logic."" (Closed)

Created:
8 years, 5 months ago by Nicolas Zea

Modified:
8 years, 5 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Revert 146262 - Revert "Revert 142517 - [Sync] Refactor sync configuration logic."" Relanding with support for purging partial types as part of SyncManager initialization. In addition, the previous version mistakenly assumed it could perform the DOWNLOADING_NIGORI state in SBH on normal restarts. This is not the case. We bring back the condition to skip the nigori downloading if HasSyncSetupCompleted is true. original review at: https://chromiumcodereview.appspot.com/10483015 BUG=129665, 133061, 133219 TEST=unit/integration tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146665