Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: content/public/browser/notification_types.h

Issue 10779042: Move notifications only used in chrome/ to chrome/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix oops Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/notification_types.h
diff --git a/content/public/browser/notification_types.h b/content/public/browser/notification_types.h
index efb0f2aa8616014935d4eb4784787298f09153b6..a1122503301bea28ecd535a300a7ed0dc6252074 100644
--- a/content/public/browser/notification_types.h
+++ b/content/public/browser/notification_types.h
@@ -146,6 +146,8 @@ enum NotificationType {
// controller associated with the state change.
NOTIFICATION_SSL_INTERNAL_STATE_CHANGED,
+ // Application-wide ----------------------------------------------------------
+
#if defined(OS_MACOSX)
// This message is sent when the application is made active (Mac OS X only
// at present). No source or details are passed.
@@ -159,23 +161,7 @@ enum NotificationType {
// are passed.
NOTIFICATION_APP_TERMINATING,
-#if defined(OS_MACOSX)
- // This notification is sent when the app has no key window, such as when
- // all windows are closed but the app is still active. No source or details
- // are provided.
- NOTIFICATION_NO_KEY_WINDOW,
-#endif
-
- // This is sent when the user has chosen to exit the app, but before any
- // browsers have closed. This is sent if the user chooses to exit
- // (via exit menu item or keyboard shortcut) or to restart the process
- // (such as in flags page), not if Chrome exists by some other means
- // (such as the user closing the last window). Note that receiving this
- // notification does not necessarily mean the process will exit
- // because the shutdown process can be cancelled by unload handler.
- // Use APP_TERMINATING for such needs.
- // The source and details are unspecified.
- NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST,
+ // Devtools ------------------------------------------------------------------
// Indicates that a devtools window is opening. The source is the
// BrowserContext* and the details is the inspected RenderViewHost*.
@@ -225,7 +211,7 @@ enum NotificationType {
// A RenderViewHost was created for a WebContents. The source is the
// associated WebContents, and the details is the RenderViewHost
// pointer.
- NOTIFICATION_RENDER_VIEW_HOST_CREATED_FOR_TAB,
+ NOTIFICATION_WEB_CONTENTS_RENDER_VIEW_HOST_CREATED,
gavinp 2012/07/18 15:35:51 Drive by nit: this isn't quite "Move notifications
// Notification than an interstitial has become associated with a tab. The
// source is the WebContents, the details not used.
@@ -332,7 +318,7 @@ enum NotificationType {
// Notification from WebContents that we have received a response from the
// renderer in response to a dom automation controller action. The source is
- // the RenderViewHost, and hte details is a DomOperationNotificationDetails.
+ // the RenderViewHost, and the details is a DomOperationNotificationDetails.
NOTIFICATION_DOM_OPERATION_RESPONSE,
// Child Processes ---------------------------------------------------------
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698