Issue 10779042: Move notifications only used in chrome/ to chrome/.

Issue 10779042: Move notifications only used in chrome/ to chrome/. (Closed)

Created:
8 years, 5 months ago by Avi (use Gerrit)

Modified:
8 years, 5 months ago

Reviewers:
gavinp, jam, sky, Miranda Callahan

CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, nkostylev+watch_chromium.org, gavinp+prer_chromium.org, tburkard+watch_chromium.org, ajwong+watch_chromium.org, jam, rginda+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, mmenke, oshima+watch_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move notifications only used in chrome/ to chrome/, renames one notification for clarity. BUG=137741 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147307

Patch Set 1 #

Patch Set 2 : fix oops #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -52 lines)			Patch
M	chrome/browser/app_controller_mac.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/base_login_display_host.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_event_router.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_id_map.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/lifetime/application_lifetime.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/managed_mode.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/thumbnail_generator.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator_browsertest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/tabs/pinned_tab_service.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/external_tab_container_win.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/user_style_sheet_watcher.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_notification_types.h	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	content/browser/browser_plugin/old/browser_plugin_host.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/notification_types.h	View		4 chunks	+5 lines, -19 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

gavinp

https://chromiumcodereview.appspot.com/10779042/diff/8002/content/public/browser/notification_types.h File content/public/browser/notification_types.h (right): https://chromiumcodereview.appspot.com/10779042/diff/8002/content/public/browser/notification_types.h#newcode214 content/public/browser/notification_types.h:214: NOTIFICATION_WEB_CONTENTS_RENDER_VIEW_HOST_CREATED, Drive by nit: this isn't quite "Move notifications ...

8 years, 5 months ago (2012-07-18 15:35:50 UTC) #2

LGTM

Expand Messages | Collapse Messages