Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: lib/dom/scripts/generator.py

Issue 10779024: Revert "Handle all registered types, not just 'Primitive' ones." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/dartgenerator.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/generator.py
diff --git a/lib/dom/scripts/generator.py b/lib/dom/scripts/generator.py
index ed474c6b703f790a9f4c613c5f4cabe7849322ae..5433a8811cdce13451a8b2840a99462c923cd2db 100644
--- a/lib/dom/scripts/generator.py
+++ b/lib/dom/scripts/generator.py
@@ -84,8 +84,10 @@ dom_frog_native_bodies = {
""",
}
-def IsRegisteredType(type_name):
- return type_name in _idl_type_registry
+def IsPrimitiveType(type_name):
+ if not type_name in _idl_type_registry:
+ return False
+ return _idl_type_registry[type_name].clazz == 'Primitive'
def ListImplementationInfo(interface, database):
"""Returns a tuple (elment_type, requires_indexer).
@@ -786,9 +788,6 @@ _idl_type_registry = {
'IDBKey': TypeData(clazz='Interface', dart_type='Dynamic', custom_to_native=True),
'StyleSheet': TypeData(clazz='Interface', conversion_includes=['CSSStyleSheet']),
'SVGElement': TypeData(clazz='Interface', custom_to_dart=True),
- 'MutationRecordArray': TypeData(clazz='Interface', # C++ pass by pointer.
- native_type='MutationRecordArray',
- dart_type='List<MutationRecord>'),
'SVGAngle': TypeData(clazz='SVGTearOff'),
'SVGLength': TypeData(clazz='SVGTearOff'),
@@ -803,7 +802,7 @@ _idl_type_registry = {
'SVGRect': TypeData(clazz='SVGTearOff', native_type='SVGPropertyTearOff<FloatRect>'),
'SVGStringList': TypeData(clazz='SVGTearOff', native_type='SVGStaticListPropertyTearOff<SVGStringList>'),
'SVGTransform': TypeData(clazz='SVGTearOff'),
- 'SVGTransformList': TypeData(clazz='SVGTearOff', native_type='SVGTransformListPropertyTearOff'),
+ 'SVGTransformList': TypeData(clazz='SVGTearOff', native_type='SVGTransformListPropertyTearOff')
}
_svg_supplemental_includes = [
« no previous file with comments | « lib/dom/scripts/dartgenerator.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698