Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 10779021: Merge 120822 - Web Inspector: don't report context ids before DidCommitLoad (Closed)

Created:
8 years, 5 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 5 months ago
Reviewers:
yurys
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 120822 - Web Inspector: don't report context ids before DidCommitLoad https://bugs.webkit.org/show_bug.cgi?id=89567 Reviewed by Pavel Feldman. When inspector state is restored only report existing context ids if "did commit load" even has already been dispatched. * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): * inspector/PageRuntimeAgent.cpp: (WebCore::PageRuntimeAgent::PageRuntimeAgent): (WebCore::PageRuntimeAgent::restore): * inspector/PageRuntimeAgent.h: (WebCore): (WebCore::PageRuntimeAgent::create): (PageRuntimeAgent): TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M Source/WebCore/inspector/InspectorController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/PageRuntimeAgent.h View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/PageRuntimeAgent.cpp View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mihai Parparita -not on Chrome
8 years, 5 months ago (2012-07-16 21:10:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698