Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 10779012: Removing LookupTransition from LookupRealNamedProperty and related utility functions. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Removing LookupTransition from LookupRealNamedProperty and related utility functions. Callsites now have to manually lookup transitions if required. This avoids unnecessary overhead of looking up transitions when we don't need them. This also allows us to use IsFound() in many places where IsProperty() was required previously. Committed: https://code.google.com/p/v8/source/detail?r=12098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -67 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 19 chunks +39 lines, -36 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/runtime.cc View 7 chunks +15 lines, -15 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL. The main change is line 2357 in src/objects.cc; requiring some manual additions of LookupTransition, ...
8 years, 5 months ago (2012-07-16 14:34:54 UTC) #1
Jakob Kummerow
8 years, 5 months ago (2012-07-16 14:45:04 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698