Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 10779011: Make android.check work by using case statement in android-run.py (Closed)

Created:
8 years, 5 months ago by haitao.feng
Modified:
8 years, 5 months ago
Reviewers:
ulan, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make android.check work

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/android-run.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
It seems that "if [ $? -ne 0 ]" does not work in ash. The ...
8 years, 5 months ago (2012-07-16 14:10:57 UTC) #1
Jakob Kummerow
I'm surprised that this change is necessary. I'm sure that Ulan successfully ran the script ...
8 years, 5 months ago (2012-07-16 14:36:34 UTC) #2
haitao.feng
8 years, 5 months ago (2012-07-16 22:01:49 UTC) #3
https://chromiumcodereview.appspot.com/10779011/diff/1/AUTHORS
File AUTHORS (right):

https://chromiumcodereview.appspot.com/10779011/diff/1/AUTHORS#newcode54
AUTHORS:54: Haitao Feng <haitao.feng@intel.com>
On 2012/07/16 14:36:34, Jakob wrote:
> Please keep this list sorted alphabetically.

Done.

Powered by Google App Engine
This is Rietveld 408576698