Parameters with function types supported + Added features in mirrors implementation

utils/apidoc/html_diff.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A script to assist in documenting the difference between the dart:html API
  * and the old DOM API.
  */
 #library('html_diff');
 
@@ skipping 28 matching lines @@
  * (e.g. `createElement`).  Unqualified member names are assumed to
  * refer to members of one of the corresponding `dart:dom_deprecated`
  * types.
  */
 class HtmlDiff {
   /** A map from `dart:dom_deprecated` members to corresponding
    * `dart:html` members. */
   final Map<MemberMirror, Set<MemberMirror>> domToHtml;
 
   /** A map from `dart:html` members to corresponding
-   * `dart:dom_deprecated` members. */
-  final Map<MemberMirror, Set<MemberMirror>> htmlToDom;
+   * `dart:dom_deprecated` members.
+   * TODO(johnniwinther): We use qualified names as keys, since mirrors
+   * (currently) are not equal between different mirror systems.
+   */
+  final Map<String, Set<MemberMirror>> htmlToDom;
 
   /** A map from `dart:dom_deprecated` types to corresponding
    * `dart:html` types.
    * TODO(johnniwinther): We use qualified names as keys, since mirrors
    * (currently) are not equal between different mirror systems.
    */
   final Map<String, Set<InterfaceMirror>> domTypesToHtml;
 
   /** A map from `dart:html` types to corresponding
    * `dart:dom_deprecated` types.
@@ skipping 20 matching lines @@
         const <String>['dart:dom_deprecated', 'dart:html'], libDir);
     _mirrors = _compilation.mirrors();
 
     // Find 'dart:dom_deprecated' by its library tag 'dom'.
     dom = findMirror(_mirrors.libraries(), 'dom');
   }
 
   HtmlDiff([bool printWarnings = false]) :
     _printWarnings = printWarnings,
     domToHtml = new Map<MemberMirror, Set<MemberMirror>>(),
-    htmlToDom = new Map<MemberMirror, Set<MemberMirror>>(),
+    htmlToDom = new Map<String, Set<MemberMirror>>(),
     domTypesToHtml = new Map<String, Set<InterfaceMirror>>(),
     htmlTypesToDom = new Map<String, Set<InterfaceMirror>>(),
     comments = new CommentMap();
 
   void warn(String s) {
     if (_printWarnings) {
       print('Warning: $s');
     }
   }
 
@@ skipping 33 matching lines @@
    */
   void _addMemberDiff(MemberMirror htmlMember, List<TypeMirror> domTypes) {
     var domMembers = htmlToDomMembers(htmlMember, domTypes);
     if (htmlMember == null && !domMembers.isEmpty()) {
       warn('dart:html member '
            '${htmlMember.surroundingDeclaration().simpleName()}.'
            '${htmlMember.simpleName()} has no corresponding dart:html member.');
     }
 
     if (htmlMember == null) return;
-    if (!domMembers.isEmpty()) htmlToDom[htmlMember] = domMembers;
+    if (!domMembers.isEmpty()) {
+      htmlToDom[htmlMember.qualifiedName()] = domMembers;
+    }
     domMembers.forEach((m) =>
         domToHtml.putIfAbsent(m, () => new Set()).add(htmlMember));
   }
 
   /**
    * Returns the `dart:dom_deprecated` [Type]s that correspond to
    * [htmlType] from `dart:html`. This can be the empty list if no
    * correspondence is found.
    */
   List<InterfaceMirror> htmlToDomTypes(InterfaceMirror htmlType) {
@@ skipping 112 matching lines @@
   Map<String, String> _getTags(String comment) {
     if (comment == null) return const <String>{};
     final re = const RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)");
     final tags = <String>{};
     for (var m in re.allMatches(comment.trim())) {
       tags[m[1]] = m[2];
     }
     return tags;
   }
 }