Parameters with function types supported + Added features in mirrors implementation

lib/dartdoc/dartdoc.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * To generate docs for a library, run this script with the path to an
  * entrypoint .dart file, like:
  *
  *     $ dart dartdoc.dart foo.dart
  *
@@ skipping 1080 matching lines @@
     bool first = true;
     bool inOptionals = false;
     for (final parameter in parameters) {
       if (!first) write(', ');
 
       if (!inOptionals && parameter.isOptional()) {
         write('[');
         inOptionals = true;
       }
 
-      annotateType(enclosingType, parameter.type(), parameter.simpleName());
+      var paramName = parameter.simpleName();
+      if (paramName.startsWith('_') &&

[floitsch, 2012/07/17 18:53:04]

It is probably not that easy. You need to check that
- there is no other parameter with the shortened name.
- adapt the links accordingly.

In any case I would prefer this to be in a separate CL.

[Johnni Winther, 2012/07/18 13:32:50]

Left out for now.

+          paramName != "_" &&
+          parameter.isInitializingFormal()) {
+        paramName = paramName.substring(1);
+      }
+      annotateType(enclosingType, parameter.type(), paramName);
 
       // Show the default value for named optional parameters.
       if (parameter.isOptional() && parameter.hasDefaultValue()) {
         write(' = ');
         write(parameter.defaultValue());
       }
 
       first = false;
     }
 
@@ skipping 144 matching lines @@
   }
 
   /** Writes a link to a human-friendly string representation for a type. */
   linkToType(ObjectMirror enclosingType, TypeMirror type) {
     if (type.isVoid) {
       // Do not generate links for void.
       // TODO(johnniwinter): Generate span for specific style?
       write('void');
       return;
     }
+    if (type.isDynamic) {
+      // Do not generate links for Dynamic.
+      write('Dynamic');
+      return;
+    }
 
     if (type.isTypeVariable) {
       // If we're using a type parameter within the body of a generic class then
       // just link back up to the class.
       write(a(typeUrl(enclosingType), type.simpleName()));
       return;
     }
 
     assert(type is InterfaceMirror);
 
@@ skipping 202 matching lines @@
   }
 
   /**
    * Returns [:true:] if [type] should be regarded as an exception.
    */
   bool isException(TypeMirror type) {
     return type.simpleName().endsWith('Exception');
   }
 }