Parameters with function types supported + Added features in mirrors implementation

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('../tree/tree.dart');
 #import('../scanner/scannerlib.dart');
 #import('../leg.dart');  // TODO(karlklose): we only need type.
 #import('../util/util.dart');
@@ skipping 198 matching lines @@
     for (Element e = this; e !== null; e = e.enclosingElement) {
       if (e.isMember() || e.isTopLevel()) {
         return e;
       }
     }
     return null;
   }
 
   String toString() {
     // TODO(johnniwinther): Test for nullness of name, or make non-nullness an
-    // invariant for all element types.
+    // invariant for all element types?
+    var nameText = name !== null ? name.slowToString() : '?';
     if (enclosingElement !== null && !isTopLevel()) {
-      String holderName = enclosingElement.name.slowToString();
-      return '$kind($holderName#${name.slowToString()})';
+      String holderName = enclosingElement.name !== null
+          ? enclosingElement.name.slowToString()
+          : '${enclosingElement.kind}?';
+      return '$kind($holderName#${nameText})';
     } else {
-      return '$kind(${name.slowToString()})';
+      return '$kind(${nameText})';
     }
   }
 
   bool _isNative = false;
   void setNative() { _isNative = true; }
   bool isNative() => _isNative;
 
   FunctionElement asFunctionElement() => null;
 }
 
@@ skipping 258 matching lines @@
 
 // This element represents a list of variable or field declaration.
 // It contains the node, and the type. A [VariableElement] always
 // references its [VariableListElement]. It forwards its
 // [computeType] and [parseNode] methods to this element.
 class VariableListElement extends Element {
   VariableDefinitions cachedNode;
   Type type;
   final Modifiers modifiers;
 
+  /**
+   * Function signature for variable of a function type. The signature is kept

[floitsch, 2012/07/17 18:53:04]

for variables with a function type.

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+   * in order to provide full information about parameter names through the

[floitsch, 2012/07/17 18:53:04]

remove "in order".

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+   * the mirror system.
+   */
+  FunctionSignature functionSignature;
+
   VariableListElement(ElementKind kind,
                       Modifiers this.modifiers,
                       Element enclosing)
     : super(null, kind, enclosing);
 
   VariableListElement.node(VariableDefinitions node,
                            ElementKind kind,
                            Element enclosing)
     : super(null, kind, enclosing),
       this.cachedNode = node,
       this.modifiers = node.modifiers;
 
   VariableDefinitions parseNode(DiagnosticListener listener) {
     return cachedNode;
   }
 
   Type computeType(Compiler compiler) {
     if (type != null) return type;
-    type = compiler.resolveTypeAnnotation(this, parseNode(compiler).type);
+    var node = parseNode(compiler);

[floitsch, 2012/07/17 18:53:04]

s/var/Node.

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+    if (node.type !== null) {
+      type = compiler.resolveTypeAnnotation(this, node.type);
+    } else {
+      // Is node.definitions exactly one FunctionExpression?
+      var link = node.definitions.nodes;

[floitsch, 2012/07/17 18:53:04]

s/var/Link

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+      if (!link.isEmpty() &&
+          link.head is FunctionExpression &&

[floitsch, 2012/07/17 18:53:04]

.asFunctionExpression() != null

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+          link.tail.isEmpty())
+      {

[floitsch, 2012/07/17 18:53:04]

move into previous line.

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+        var functionExpression = link.head;

[floitsch, 2012/07/17 18:53:04]

s/var/FunctionExpression

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+        // We found exactly one FunctionExpression
+        compiler.withCurrentElement(this, () {
+          functionSignature = compiler.resolveFunctionExpression(

[floitsch, 2012/07/17 18:53:04]

nit: I would prefer a new line after the "=" (if it fits).

[Johnni Winther, 2012/07/18 13:32:50]

Done.

+              this, functionExpression);
+        });
+        type = compiler.computeFunctionType(compiler.functionClass,
+                                            functionSignature);
+      } else {
+        type = compiler.types.dynamicType;
+      }
+    }
+    assert(type != null);
     return type;
   }
 
   Token position() => cachedNode.getBeginToken();
 }
 
 class ForeignElement extends Element {
   ForeignElement(SourceString name, ContainerElement enclosingElement)
     : super(name, ElementKind.FOREIGN, enclosingElement);
 
@@ skipping 619 matching lines @@
   final Node node;
   Type bound;
   Type type;
   TypeVariableElement(name, Element enclosing, this.node, this.type,
                       [this.bound])
     : super(name, ElementKind.TYPE_VARIABLE, enclosing);
   Type computeType(compiler) => type;
   Node parseNode(compiler) => node;
   toString() => "${enclosingElement.toString()}.${name.slowToString()}";
 }