Use the script helper to build of content shell on Android

Use the script helper to build of content shell on Android


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146954

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148053

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150292

[yongsheng, 2012-07-15 02:39:16]

This is the second step John proposed.

[jam, 2012-07-16 05:25:11]

i defer my lgtm to jrg

[John Grabowski, 2012-07-16 20:38:28]

LGTM

[commit-bot: I haz the power, 2012-07-17 01:29:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10779008/1

[commit-bot: I haz the power, 2012-07-17 03:35:38]

Change committed as 146954

[Satish, 2012-07-17 14:50:03]

After this landed I get the following error when running 'android_gyp'

KeyError: 'Undefined variable CONFIGURATION_NAME in
/usr/local/google/chrome/src/content/content.gyp while loading dependencies of
/usr/local/google/chrome/src/build/all_android.gyp while trying to load
/usr/local/google/chrome/src/build/all_android.gyp'

Any idea where CONFIGURATION_NAME is defined and why I'm not seeing it defined?

[John Grabowski, 2012-07-17 16:51:57]

On 2012/07/17 14:50:03, Satish wrote:
> After this landed I get the following error when running 'android_gyp'
> 
> KeyError: 'Undefined variable CONFIGURATION_NAME in
> /usr/local/google/chrome/src/content/content.gyp while loading dependencies of
> /usr/local/google/chrome/src/build/all_android.gyp while trying to load
> /usr/local/google/chrome/src/build/all_android.gyp'
> 
> Any idea where CONFIGURATION_NAME is defined and why I'm not seeing it
defined?

It's in gyp; http://codereview.chromium.org/10661052/
Maybe you need to 'gclient sync', not just 'git pull'.

[Yaron, 2012-07-18 18:29:44]

On 2012/07/17 16:51:57, John Grabowski wrote:
> On 2012/07/17 14:50:03, Satish wrote:
> > After this landed I get the following error when running 'android_gyp'
> > 
> > KeyError: 'Undefined variable CONFIGURATION_NAME in
> > /usr/local/google/chrome/src/content/content.gyp while loading dependencies
of
> > /usr/local/google/chrome/src/build/all_android.gyp while trying to load
> > /usr/local/google/chrome/src/build/all_android.gyp'
> > 
> > Any idea where CONFIGURATION_NAME is defined and why I'm not seeing it
> defined?
> 
> It's in gyp; http://codereview.chromium.org/10661052/
> Maybe you need to 'gclient sync', not just 'git pull'.

FYI: Unfortunately this breaks the ninja build for Android as it doesn't define
the CONFIGURATION_NAME flag so I'm going to revert it.

You can test by doing: export GYP_GENERATORS=ninja and then running android_gyp.
We still need to get a bot up for this configuration but many developers are
using this build variant.

[Yaron, 2012-07-18 18:36:38]

On 2012/07/18 18:29:44, Yaron wrote:
> On 2012/07/17 16:51:57, John Grabowski wrote:
> > On 2012/07/17 14:50:03, Satish wrote:
> > > After this landed I get the following error when running 'android_gyp'
> > > 
> > > KeyError: 'Undefined variable CONFIGURATION_NAME in
> > > /usr/local/google/chrome/src/content/content.gyp while loading
dependencies
> of
> > > /usr/local/google/chrome/src/build/all_android.gyp while trying to load
> > > /usr/local/google/chrome/src/build/all_android.gyp'
> > > 
> > > Any idea where CONFIGURATION_NAME is defined and why I'm not seeing it
> > defined?
> > 
> > It's in gyp; http://codereview.chromium.org/10661052/
> > Maybe you need to 'gclient sync', not just 'git pull'.
> 
> FYI: Unfortunately this breaks the ninja build for Android as it doesn't
define
> the CONFIGURATION_NAME flag so I'm going to revert it.
> 
> You can test by doing: export GYP_GENERATORS=ninja and then running
android_gyp.
> We still need to get a bot up for this configuration but many developers are
> using this build variant.

Ok, so this was reverted with 147275. If I cd to gyp and do a grep I see:

pylib/gyp/generator/make.py:  'CONFIGURATION_NAME': '$(BUILDTYPE)',
pylib/gyp/generator/msvs.py:    'CONFIGURATION_NAME': '$(ConfigurationName)',
pylib/gyp/generator/scons.py:    'CONFIGURATION_NAME': '${CONFIG_NAME}',
pylib/gyp/generator/xcode.py:  'CONFIGURATION_NAME': '$(CONFIGURATION)',

So for some reason the ninja generator is missing this flag which seems to be
univeral across gyp flavours. Please add it, roll gyp into chromium and then
re-land.

[yongsheng, 2012-07-24 03:21:05]

On 2012/07/18 18:36:38, Yaron wrote:
> On 2012/07/18 18:29:44, Yaron wrote:
> > On 2012/07/17 16:51:57, John Grabowski wrote:
> > > On 2012/07/17 14:50:03, Satish wrote:
> > > > After this landed I get the following error when running 'android_gyp'
> > > > 
> > > > KeyError: 'Undefined variable CONFIGURATION_NAME in
> > > > /usr/local/google/chrome/src/content/content.gyp while loading
> dependencies
> > of
> > > > /usr/local/google/chrome/src/build/all_android.gyp while trying to load
> > > > /usr/local/google/chrome/src/build/all_android.gyp'
> > > > 
> > > > Any idea where CONFIGURATION_NAME is defined and why I'm not seeing it
> > > defined?
> > > 
> > > It's in gyp; http://codereview.chromium.org/10661052/
> > > Maybe you need to 'gclient sync', not just 'git pull'.
> > 
> > FYI: Unfortunately this breaks the ninja build for Android as it doesn't
> define
> > the CONFIGURATION_NAME flag so I'm going to revert it.
> > 
> > You can test by doing: export GYP_GENERATORS=ninja and then running
> android_gyp.
> > We still need to get a bot up for this configuration but many developers are
> > using this build variant.
> 
> Ok, so this was reverted with 147275. If I cd to gyp and do a grep I see:
> 
> pylib/gyp/generator/make.py:  'CONFIGURATION_NAME': '$(BUILDTYPE)',
> pylib/gyp/generator/msvs.py:    'CONFIGURATION_NAME': '$(ConfigurationName)',
> pylib/gyp/generator/scons.py:    'CONFIGURATION_NAME': '${CONFIG_NAME}',
> pylib/gyp/generator/xcode.py:  'CONFIGURATION_NAME': '$(CONFIGURATION)',
> 
> So for some reason the ninja generator is missing this flag which seems to be
> univeral across gyp flavours. Please add it, roll gyp into chromium and then
> re-land.
thanks, i'll re-land it.

[commit-bot: I haz the power, 2012-07-24 03:21:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10779008/1

[commit-bot: I haz the power, 2012-07-24 06:02:50]

Change committed as 148053

[Yaron, 2012-07-24 19:49:41]

On 2012/07/24 06:02:50, I haz the power (commit-bot) wrote:
> Change committed as 148053

Rolled back again in 148174. As I indicated in the above message, you need to
make sure that the gyp revision is actually rolled into chromium before landing
this. From DEPS we ohnly have revision 1431 but you need 1434

[yongsheng, 2012-07-25 01:28:49]

On 2012/07/24 19:49:41, Yaron wrote:
> On 2012/07/24 06:02:50, I haz the power (commit-bot) wrote:
> > Change committed as 148053
> 
> Rolled back again in 148174. As I indicated in the above message, you need to
> make sure that the gyp revision is actually rolled into chromium before
landing
> this. From DEPS we ohnly have revision 1431 but you need 1434
ok, I'll check the DEPS and wait for the update.

[yongsheng, 2012-07-25 01:33:37]

On 2012/07/25 01:28:49, yongsheng wrote:
> On 2012/07/24 19:49:41, Yaron wrote:
> > On 2012/07/24 06:02:50, I haz the power (commit-bot) wrote:
> > > Change committed as 148053
> > 
> > Rolled back again in 148174. As I indicated in the above message, you need
to
> > make sure that the gyp revision is actually rolled into chromium before
> landing
> > this. From DEPS we ohnly have revision 1431 but you need 1434
> ok, I'll check the DEPS and wait for the update.
sorry about that.

[yongsheng, 2012-08-06 02:41:54]

now DEPS for gyp is 1451, which is greater than 1434.
so will commit this soon.

[commit-bot: I haz the power, 2012-08-07 01:20:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10779008/1

[commit-bot: I haz the power, 2012-08-07 01:20:22]

Failed to apply patch for content/content_shell.gypi:
While running patch -p1 --forward --force;
patching file content/content_shell.gypi
Hunk #1 FAILED at 608.
1 out of 1 hunk FAILED -- saving rejects to file content/content_shell.gypi.rej

[commit-bot: I haz the power, 2012-08-07 05:32:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10779008/20002

[commit-bot: I haz the power, 2012-08-07 06:54:28]

Change committed as 150292