Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10778044: Always enable dom automation for browser_tests. This avoids developers having to call EnableDOMAuto… (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, dcheng, scheib+watch_chromium.org, kinuko+watch, Ilya Sherman, markusheintz_, cbentzel+watch_chromium.org, kkania, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, gbillock+watch_chromium.org, dbeam+watch-ntp_chromium.org, jennb, dyu1, jianli, gavinp+prer_chromium.org, estade+watch_chromium.org, mihaip-chromium-reviews_chromium.org, Dmitry Titov, Aaron Boodman, dominich+watch_chromium.org, robertshield, rdsmith+dwatch_chromium.org, smckay+watch_chromium.org, mmenke
Visibility:
Public.

Description

Always enable dom automation for browser_tests. This avoids developers having to call EnableDOMAutomation manually, which is not evident. ui_tests used to do this automatically. Also while at it, removed needless InProcessBrowserTest::SetUpCommandLine() calls. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -160 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/automation/automation_misc_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/record/record_api_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_install_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/net/load_timing_observer_browsertest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prefetch_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/automation/dom_automation_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_crash_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/gpu/webgl_conformance_tests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/perf/rendering/latency_tests.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/test/layout_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 5 months ago (2012-07-17 23:36:27 UTC) #1
awong
8 years, 5 months ago (2012-07-18 18:09:20 UTC) #2 
LGTM

Sorry for the delay.

Powered by Google App Engine
This is Rietveld 408576698