Don't turn on accessibility automatically on Linux.

Don't turn on accessibility automatically on Linux.

With this change, a Linux user can still manually switch on
accessibility support with the --force-renderer-accessibility flag,
but it will never get switched on automatically. Let's merge this to
M21 so it never happens to users who don't want it, then come up with
a smarter way to detect automatically later.

BUG=137537
TEST=Run Chrome with "assistive technology" flag on, observe no slowdown in gmail anymore.
TBR=ben

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147074

[David Tseng, 2012-07-17 19:33:44]

lgtm

On Tue, Jul 17, 2012 at 12:28 PM,  <dmazzoni@chromium.org> wrote:
> Reviewers: David Tseng, Michael Moss,
>
> Description:
> Don't turn on accessibility automatically on Linux.
>
> With this change, a Linux user can still manually switch on
> accessibility support with the --force-renderer-accessibility flag,
> but it will never get switched on automatically. Let's merge this to
> M21 so it never happens to users who don't want it, then come up with
> a smarter way to detect automatically later.
>
> BUG=137537
> TEST=Run Chrome with "assistive technology" flag on, observe no slowdown in
> gmail anymore.
> TBR=ben
>
>
> Please review this at http://codereview.chromium.org/10778040/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M content/browser/renderer_host/render_widget_host_view_gtk.cc
>
>
> Index: content/browser/renderer_host/render_widget_host_view_gtk.cc
> diff --git a/content/browser/renderer_host/render_widget_host_view_gtk.cc
> b/content/browser/renderer_host/render_widget_host_view_gtk.cc
> index
>
43588272859094befc61962906218aba5b10ca94..9271fe63035dd90336df9baec10129f592f794e8
> 100644
> --- a/content/browser/renderer_host/render_widget_host_view_gtk.cc
> +++ b/content/browser/renderer_host/render_widget_host_view_gtk.cc
> @@ -1499,9 +1499,6 @@ void
> RenderWidgetHostViewGtk::OnAccessibilityNotifications(
>  }
>
>  AtkObject* RenderWidgetHostViewGtk::GetAccessible() {
> -  RenderWidgetHostImpl::From(GetRenderWidgetHost())->
> -      SetAccessibilityMode(AccessibilityModeComplete);
> -
>    if (!browser_accessibility_manager_.get()) {
>      GtkWidget* parent = gtk_widget_get_parent(view_.get());
>      browser_accessibility_manager_.reset(
>
>

[Michael Moss, 2012-07-17 19:33:54]

LGTM