The deferred handes list belongs to the Isolate and not to the

The deferred handes list belongs to the Isolate and not to the
HandleScopeImplementer (since it isn't something specific to a
particular thread executing on an Isolate). This patch ensures correct
traversal of the handles when when multiple compilations are queued
up.


BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=12134

[danno, 2012-07-18 13:36:17]

http://codereview.chromium.org/10778036/diff/1/src/api.h
File src/api.h (right):

http://codereview.chromium.org/10778036/diff/1/src/api.h#newcode406
src/api.h:406: isolate->deferred_handles_head_ = this;
I don't think you should reach into the isolate like this. Expose a protected
next()/previous() and set_next()/set_previous() method on the deferred handles.
From the constructor here, you should call
isolate->RegisterDeferredHandles(this) or something of the like. The
"friendness" should only go in one direction.

http://codereview.chromium.org/10778036/diff/1/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/10778036/diff/1/src/isolate.cc#newcode482
src/isolate.cc:482: deferred;
Use explicit test against NULL

http://codereview.chromium.org/10778036/diff/1/src/isolate.h
File src/isolate.h (right):

http://codereview.chromium.org/10778036/diff/1/src/isolate.h#newcode1287
src/isolate.h:1287: friend class DeferredHandles;
No friend in this direction.

[sanjoy, 2012-07-18 14:00:43]

Removed tangled dependency.

The Isolate now has methods to link / unlink DeferredHandles structures, called
as a part of DeferredHandles construction and destruction.  The DeferredHandles
class no longer deals with the linked list directly.

http://codereview.chromium.org/10778036/diff/1/src/api.h
File src/api.h (right):

http://codereview.chromium.org/10778036/diff/1/src/api.h#newcode406
src/api.h:406: isolate->deferred_handles_head_ = this;
On 2012/07/18 13:36:17, danno wrote:
> I don't think you should reach into the isolate like this. Expose a protected
> next()/previous() and set_next()/set_previous() method on the deferred
handles.
> From the constructor here, you should call
> isolate->RegisterDeferredHandles(this) or something of the like. The
> "friendness" should only go in one direction.

Done.

http://codereview.chromium.org/10778036/diff/1/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/10778036/diff/1/src/isolate.cc#newcode482
src/isolate.cc:482: deferred;
On 2012/07/18 13:36:17, danno wrote:
> Use explicit test against NULL

Done.

http://codereview.chromium.org/10778036/diff/1/src/isolate.h
File src/isolate.h (right):

http://codereview.chromium.org/10778036/diff/1/src/isolate.h#newcode1287
src/isolate.h:1287: friend class DeferredHandles;
On 2012/07/18 13:36:17, danno wrote:
> No friend in this direction.

Done.

[danno, 2012-07-18 14:06:11]

lgtm