Issue 10778009: Add histogram for total heap fragmentation, don't report fragmentation for new space, and report fr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10778009: Add histogram for total heap fragmentation, don't report fragmentation for new space, and report fr… (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add histogram for total heap fragmentation, don't report fragmentation for new space, and report fragmentation, not usage BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=12099

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 2

Patch Set 3 : updates #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -20 lines)			Patch
	M	src/heap.cc	View	1 2	1 chunk	+30 lines, -18 lines	0 comments	Download
	M	src/v8-counters.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

As discussed offline, the total fragmentation is off because of an integer overflow. https://chromiumcodereview.appspot.com/10778009/diff/3001/src/v8-counters.h File ...

8 years, 5 months ago (2012-07-16 14:41:47 UTC) #2

jochen (gone - plz use gerrit)

https://chromiumcodereview.appspot.com/10778009/diff/3001/src/v8-counters.h File src/v8-counters.h (right): https://chromiumcodereview.appspot.com/10778009/diff/3001/src/v8-counters.h#newcode58 src/v8-counters.h:58: V8.MemoryExternalFragmentationNewSpace) \ On 2012/07/16 14:41:47, Michael Starzinger wrote: > ...

8 years, 5 months ago (2012-07-16 14:59:11 UTC) #3

LGTM. Landing.

Expand Messages | Collapse Messages