Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: build/common.gypi

Issue 10777006: Use the system zlib and ICU when building with the Android build system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 9953c57b20cda03919a550381a4ab8aadb7f4e31..efe1dc9cfb5e4f2a5ab59536db58e532aada23a4 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -951,23 +951,15 @@
'use_system_skia%': '0',
'use_system_harfbuzz%': '0',
- # Use the system icu.
- 'use_system_icu%': 0,
-
# TODO(yfriedman): Remove once unit_tests can link for Android.
# To override it specify:
# GYP_DEFINES="$GYP_DEFINES android_unit_test_target_type=executable"
# android_gyp
'android_unit_test_target_type%': 'static_library',
- 'conditions': [
- # Choose static link by build type.
- ['android_build_type==0', {
- 'static_link_system_icu%': 1,
- }, {
- 'static_link_system_icu%': 0,
- }],
- ],
+ # Always use the system zlib.
+ 'use_system_zlib%': 1,
+
# TODO(steveblock): Investigate using the system versions of sqlite and
# libjpeg.
# Enable to use system sqlite.
@@ -979,6 +971,8 @@
# Enable to use the system stlport, otherwise statically
# link the NDK one?
'use_system_stlport%': '<(android_build_type)',
+ # Enable to use the system ICU.
+ 'use_system_icu%': '<(android_build_type)',
# Copy it out one scope.
'android_build_type%': '<(android_build_type)',
}], # OS=="android"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698