Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: chrome/browser/extensions/api/api_resource_controller.cc

Issue 10777003: Refactor APIResourceController to ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge/antony/fix build. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/extensions/api/api_resource_controller.h"
6 #include "chrome/browser/extensions/api/serial/serial_connection.h"
7 #include "chrome/browser/extensions/api/socket/socket.h"
8 #include "chrome/browser/extensions/api/usb/usb_device_resource.h"
9 #include "content/public/browser/browser_thread.h"
10
11 using content::BrowserThread;
12
13 namespace extensions {
14
15 APIResourceController::APIResourceController()
16 : next_api_resource_id_(1),
17 socket_resource_map_(new APIResourceMap),
18 serial_connection_resource_map_(new APIResourceMap),
19 usb_device_resource_map_(new APIResourceMap) {}
20
21 APIResourceController::~APIResourceController() {
22 // If this check failed, then a unit test was using an APIResource but
23 // didn't provide the IO/FILE thread message loops needed for those resources
24 // to do their job (including destroying themselves at shutdown).
25 DCHECK(BrowserThread::IsMessageLoopValid(BrowserThread::IO));
26 DCHECK(BrowserThread::IsMessageLoopValid(BrowserThread::FILE));
27
28 BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE,
29 socket_resource_map_);
30 BrowserThread::DeleteSoon(BrowserThread::FILE, FROM_HERE,
31 serial_connection_resource_map_);
32 BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE,
33 usb_device_resource_map_);
34 }
35
36 APIResourceController::APIResourceMap*
37 APIResourceController::GetResourceMapForType(
38 APIResource::APIResourceType api_resource_type) const {
39 switch (api_resource_type) {
40 case APIResource::SocketResource:
41 return socket_resource_map_;
42 case APIResource::SerialConnectionResource:
43 return serial_connection_resource_map_;
44 case APIResource::UsbDeviceResource:
45 return usb_device_resource_map_;
46 default:
47 NOTREACHED();
48 return NULL;
49 }
50 }
51
52 APIResource* APIResourceController::GetAPIResource(
53 APIResource::APIResourceType api_resource_type,
54 int api_resource_id) const {
55 // TODO(miket): verify that the extension asking for the APIResource is the
56 // same one that created it.
57 APIResourceMap* map = GetResourceMapForType(api_resource_type);
58 APIResourceMap::const_iterator i = map->find(api_resource_id);
59 if (i == map->end())
60 return NULL;
61
62 APIResource* resource = i->second.get();
63
64 // This DCHECK is going to catch some legitimate application-developer
65 // errors, where someone asks for resource of Type A with the wrong ID that
66 // happens to belong to a resource of Type B. But in debug mode, it's more
67 // likely to catch a silly copy/paste coding error while developing a new
68 // resource type, and unfortunately we can't really tell the difference.
69 // We'll choose the more informative outcome (loud explosion during debug)
70 // rather than a mysterious empty resource returned to JavaScript.
71 DCHECK(!resource || resource->api_resource_type() == api_resource_type);
72
73 if (resource && resource->api_resource_type() != api_resource_type)
74 resource = NULL;
75
76 return resource;
77 }
78
79 int APIResourceController::AddAPIResource(APIResource* api_resource) {
80 APIResourceMap* map = GetResourceMapForType(
81 api_resource->api_resource_type());
82 int id = GenerateAPIResourceId();
83 if (id > 0) {
84 linked_ptr<APIResource> resource_ptr(api_resource);
85 (*map)[id] = resource_ptr;
86 return id;
87 }
88 return 0;
89 }
90
91 bool APIResourceController::RemoveAPIResource(
92 APIResource::APIResourceType api_resource_type, int api_resource_id) {
93 APIResource* api_resource = GetAPIResource(api_resource_type,
94 api_resource_id);
95 if (!api_resource)
96 return false;
97 APIResourceMap* map = GetResourceMapForType(
98 api_resource->api_resource_type());
99 map->erase(api_resource_id);
100 return true;
101 }
102
103 bool APIResourceController::RemoveSocket(int api_resource_id) {
104 return RemoveAPIResource(APIResource::SocketResource, api_resource_id);
105 }
106
107 bool APIResourceController::RemoveSerialConnection(int api_resource_id) {
108 return RemoveAPIResource(APIResource::SerialConnectionResource,
109 api_resource_id);
110 }
111
112 bool APIResourceController::RemoveUsbDeviceResource(int api_resource_id) {
113 return RemoveAPIResource(APIResource::UsbDeviceResource, api_resource_id);
114 }
115
116 // TODO(miket): consider partitioning the ID space by extension ID
117 // to make it harder for extensions to peek into each others' resources.
118 int APIResourceController::GenerateAPIResourceId() {
119 return next_api_resource_id_++;
120 }
121
122 Socket* APIResourceController::GetSocket(int api_resource_id) const {
123 CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
124 return static_cast<Socket*>(GetAPIResource(APIResource::SocketResource,
125 api_resource_id));
126 }
127
128 SerialConnection* APIResourceController::GetSerialConnection(
129 int api_resource_id) const {
130 CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
131 return static_cast<SerialConnection*>(
132 GetAPIResource(APIResource::SerialConnectionResource, api_resource_id));
133 }
134
135 UsbDeviceResource* APIResourceController::GetUsbDeviceResource(
136 int api_resource_id) const {
137 CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
138 return static_cast<UsbDeviceResource*>(GetAPIResource(
139 APIResource::UsbDeviceResource, api_resource_id));
140 }
141
142 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/api_resource_controller.h ('k') | chrome/browser/extensions/api/api_resource_event_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698