Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 10775002: Added storage to manifest permissions table. (Closed)

Created:
8 years, 5 months ago by mkearney
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Added storage to manifest permissions table.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/common/extensions/docs/apps/manifest.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/manifest.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
lgtm Only noticed this review because I happened to glance at codereview.chromium.org. Need to Publish+Mail ...
8 years, 5 months ago (2012-07-11 07:25:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@google.com/10775002/1
8 years, 5 months ago (2012-07-11 15:14:34 UTC) #2
commit-bot: I haz the power
Presubmit check for 10775002-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-11 15:14:37 UTC) #3
Mihai Parparita -not on Chrome
Landed as http://crrev.com/146169 Mihai On Wed, Jul 11, 2012 at 8:14 AM, <commit-bot@chromium.org> wrote: > ...
8 years, 5 months ago (2012-07-11 19:26:48 UTC) #4
mkearney
8 years, 5 months ago (2012-07-11 20:06:38 UTC) #5
Thanks, Mihai.

On Wed, Jul 11, 2012 at 12:26 PM, Mihai Parparita <mihaip@chromium.org>wrote:

> Landed as http://crrev.com/146169
>
> Mihai
>
>
> On Wed, Jul 11, 2012 at 8:14 AM, <commit-bot@chromium.org> wrote:
>
>> Presubmit check for 10775002-1 failed and returned exit status 1.
>>
>> Running presubmit commit checks ...
>>
>> ** Presubmit Messages **
>> If this change has an associated bug, add BUG=[bug number].
>>
>> If this change requires manual test instructions to QA team, add
>> TEST=[instructions].
>>
>> ** Presubmit Warnings **
>> This change modifies the extension docs but the generated docs have not
>> been
>> updated properly. See chrome/common/extensions/docs/**README.txt for
>> more info.
>>  - Changes to chrome/common/extensions/docs/**static/manifest.html not
>> reflected
>> in generated doc.
>> First build DumpRenderTree, then update the docs by running:
>>   chrome/common/extensions/docs/**build/build.py
>>
>> Was the presubmit check useful? Please send feedback & hate mail to
>> maruel@chromium.org!
>>
>>
>>
https://chromiumcodereview.**appspot.com/10775002/<https://chromiumcodereview...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698