Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 107693002: Move build/build_config_functions.h to sandbox/ (Closed)

Created:
7 years ago by jln (very slow on Chromium)
Modified:
7 years ago
Reviewers:
jww
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Move build/build_config_functions.h to sandbox/ There is not much support for build/build_config_functions.h, as highlighted in http://goo.gl/3ufXOJ. Move it away. This is a reland of https://chromiumcodereview.appspot.com/106163008/ TBR=jww@chromium.org

Patch Set 1 #

Patch Set 2 : Move build:: to sandbox:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -148 lines) Patch
M build/build_config.h View 1 chunk +0 lines, -3 lines 0 comments Download
D build/build_config_functions.h View 1 chunk +0 lines, -110 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + sandbox/linux/services/build_config_functions.h View 3 chunks +5 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/107693002/20001
7 years ago (2013-12-06 04:18:17 UTC) #1
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=32378
7 years ago (2013-12-06 05:18:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/107693002/20001
7 years ago (2013-12-06 05:46:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=32461
7 years ago (2013-12-06 07:37:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/107693002/20001
7 years ago (2013-12-06 08:07:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=32484
7 years ago (2013-12-06 08:43:32 UTC) #6
jln (very slow on Chromium)
7 years ago (2013-12-06 08:53:46 UTC) #7 
I think android_aosp is borked, but the failure is very weird. I'm not going to
take chanced and I'm reverting https://chromiumcodereview.appspot.com/103293003/
instead.

Powered by Google App Engine
This is Rietveld 408576698