Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: lib/unittest/future_matchers.dart

Issue 10766006: Print the stack traces for Future expectations that raise exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/unittest/core_matchers.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Matches a [Future] that completes successfully with a value. Note that this 6 * Matches a [Future] that completes successfully with a value. Note that this
7 * creates an asynchronous expectation. The call to `expect()` that includes 7 * creates an asynchronous expectation. The call to `expect()` that includes
8 * this will return immediately and execution will continue. Later, when the 8 * this will return immediately and execution will continue. Later, when the
9 * future completes, the actual expectation will run. 9 * future completes, the actual expectation will run.
10 * 10 *
(...skipping 15 matching lines...) Expand all
26 26
27 class _Completes extends BaseMatcher { 27 class _Completes extends BaseMatcher {
28 final Matcher _matcher; 28 final Matcher _matcher;
29 29
30 const _Completes(this._matcher); 30 const _Completes(this._matcher);
31 31
32 bool matches(item) { 32 bool matches(item) {
33 if (item is! Future) return false; 33 if (item is! Future) return false;
34 34
35 item.onComplete(expectAsync1((future) { 35 item.onComplete(expectAsync1((future) {
36 expect(future.hasValue, 36 var reason = 'Expected future to complete successfully, but it failed '
37 reason: 'Expected future to complete successfully, but it failed'); 37 'with ${future.exception}';
38 if (future.stackTrace != null) {
39 var stackTrace = future.stackTrace.toString();
40 stackTrace = ' ${stackTrace.replaceAll('\n', '\n ')}';
41 reason = '$reason\nStack trace:\n$stackTrace';
42 }
43
44 expect(future.hasValue, reason: reason);
38 if (_matcher != null) expect(future.value, _matcher); 45 if (_matcher != null) expect(future.value, _matcher);
39 })); 46 }));
40 47
41 return true; 48 return true;
42 } 49 }
43 50
44 Description describe(Description description) { 51 Description describe(Description description) {
45 if (_matcher == null) { 52 if (_matcher == null) {
46 description.add('completes successfully'); 53 description.add('completes successfully');
47 } else { 54 } else {
48 description.add('completes to a value that ').addDescriptionOf(_matcher); 55 description.add('completes to a value that ').addDescriptionOf(_matcher);
49 } 56 }
50 return description; 57 return description;
51 } 58 }
52 } 59 }
OLDNEW
« no previous file with comments | « lib/unittest/core_matchers.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698